Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to convert bytecode to hex, and set as None if it fails. Includes version bump to v0.0.29 #108

Merged
merged 2 commits into from
May 10, 2024

Conversation

slundqui
Copy link
Contributor

No description provided.

@slundqui slundqui changed the title Attempt to convert bytecode to hex, and set as None if it fails Attempt to convert bytecode to hex, and set as None if it fails. Includes version bump to v0.0.29 May 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (ab074e9) to head (01738e7).

Files Patch % Lines
pypechain/templates/utilities.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   67.26%   67.34%   +0.08%     
==========================================
  Files          49       49              
  Lines        2337     2346       +9     
==========================================
+ Hits         1572     1580       +8     
- Misses        765      766       +1     
Flag Coverage Δ
unittests 67.34% <88.88%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dpaiton dpaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; might want @sentilesdal to check it out before merging bc I haven't looked a this stuff in a while

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@slundqui slundqui merged commit 90884f2 into main May 10, 2024
6 checks passed
@slundqui slundqui deleted the slundquist/bytecode-hotfix branch May 10, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants