Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Errors to generated types files. #101

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Add Errors to generated types files. #101

merged 3 commits into from
Jan 30, 2024

Conversation

sentilesdal
Copy link
Contributor

Add Errors to the generated types files. See ExampleTypes.py file for a good example.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (9810497) 66.76% compared to head (9ed4c31) 67.01%.

Files Patch % Lines
pypechain/utilities/abi.py 50.00% 26 Missing ⚠️
pypechain/render/contract.py 16.66% 10 Missing ⚠️
pypechain/render/types.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   66.76%   67.01%   +0.24%     
==========================================
  Files          46       46              
  Lines        1974     2101     +127     
==========================================
+ Hits         1318     1408      +90     
- Misses        656      693      +37     
Flag Coverage Δ
unittests 67.01% <71.96%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@slundqui slundqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sentilesdal sentilesdal merged commit 8f1af44 into main Jan 30, 2024
6 checks passed
@sentilesdal sentilesdal deleted the matt-add-errors branch January 30, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants