remove unused colors and classes #872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jackburrus
commented
Apr 3, 2024
| @@ -20,7 +20,7 @@ export function Tabs({ | |||
| <input | |||
| key={id} | |||
| className={classNames( | |||
| "daisy-tab font-chakraPetch", | |||
There was a problem hiding this comment.
Removed this as it looked strange having these tabs as a different font from the transactions table. I think this font looks good as the Market header and the Hero text on the landing. Curious your thoughts @DannyDelott?
DannyDelott
reviewed
Apr 3, 2024
Comment on lines
-6
to
-35
| aquamarine: { | ||
| 100: "#E8FFF7", | ||
| DEFAULT: "#15FFAB", | ||
| 600: "#11cc89", | ||
| }, | ||
| "sky-blue": { | ||
| 100: "#95ECFF", | ||
| DEFAULT: "#14D0F9", | ||
| 800: "#00A7CC", | ||
| }, | ||
| eggplant: { | ||
| 100: "#F3E9ED", | ||
| DEFAULT: "#753F53", | ||
| 600: "#462632", | ||
| }, | ||
|
|
||
| // Used for primary buttons, links, tabs and states | ||
| lime: { | ||
| 100: "#DFFF99", | ||
| DEFAULT: "#BAFF29", | ||
| 800: "#8BCC00", | ||
| }, | ||
| // Used for interactive text and components such as tabs, tags and | ||
| // sliders | ||
| teal: { | ||
| 100: "#E8FCFC", | ||
| DEFAULT: "#9BF3F0", | ||
| 800: "#49E9E4", | ||
| 900: "#16B6B1", | ||
| }, |
There was a problem hiding this comment.
I think we need to check the inline comments for the daisy theme – we should keep the colors we're using but not referencing directly from the tailwind theme.
DannyDelott
reviewed
Apr 3, 2024
| @@ -3,37 +3,6 @@ module.exports = { | |||
| content: ["./src/**/*.{js,ts,jsx,tsx,css}", "index.html"], | |||
| theme: { | |||
| colors: { | |||
| aquamarine: { | |||
| 100: "#E8FFF7", | |||
| DEFAULT: "#15FFAB", | |||
There was a problem hiding this comment.
This is the color we use for our primary daisy color, we should keep it here since we reference it in the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.