You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first in a series of PR's that migrates our openlongs table to fetch the data from transfer single events. This will be useful to show positions that have been transferred to a users wallet from another address. A few things to note:
This creates two new functions inside ReadHyperdrive. The first fetches all longs received by a user, the second fetches the long details using the assetId. If the user received the long from an address other than the ZERO_ADDRESS the bond details can't be calculated.
We should come up with a more scalable naming structure for some of these functions and types. This is what I have in mind: "[Status][PositionType]Position[Action]". For example: "OpenLongPositionReceived" or "OpenLongPositionSent". Curious your thoughts @DannyDelott.
I will implement these readhyperdrive methods in the table in the next PR.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
minor: We should use Promise.all + Array.map for this, otherwise openLongPositionsReceived will be returned before the asynchronous operations inside the loop have finished.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first in a series of PR's that migrates our openlongs table to fetch the data from transfer single events. This will be useful to show positions that have been transferred to a users wallet from another address. A few things to note: