Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retry queries #1156

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Don't retry queries #1156

merged 1 commit into from
Jun 7, 2024

Conversation

DannyDelott
Copy link
Contributor

Finding myself doing this a few times now, and I think it's safe to just turn off globally.

If we need to set a retries for a specific query that's totally fine. We do this in place already, in useAddressScreen, where a custom retries: 6 is set.

Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: 7cabc54

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-monorepo-hyperdrive-trading ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 3:29pm
hyperdrive-sepolia-production ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 3:29pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 3:29pm
testnet-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 3:29pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Jun 7, 2024 3:29pm
trading-competition ⬜️ Ignored (Inspect) Jun 7, 2024 3:29pm

@DannyDelott DannyDelott merged commit 9382a46 into main Jun 7, 2024
12 checks passed
@DannyDelott DannyDelott deleted the danny-queryClient-retry-param branch June 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants