disable gallery/document links for profiles without a chat #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove superfluous chatId parameter from ContactDetailViewController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr disables the gallery/document links for profiles without a chat (they can be opened from new chat -> swipe contact without a chat -> info)
already in the past, the gallery was only opened for context.getChatIdByContactId(), not for the given chatId, this pr always sets the used chatId to context.getChatIdByContactId() - and makes the chatId for the ContactDetailsViewController superfluous (the chat-details shown along with the contact always belong to the one-to-one-chat by nature, never to some group)
fixes #706