Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to bottom when scrolled to bottom #2231

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Scroll to bottom when scrolled to bottom #2231

merged 6 commits into from
Jul 12, 2024

Conversation

zeitschlag
Copy link
Collaborator

Fixes #2129

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, works great - and fixes the reproduce-way i just added to #2129

the "scroll down" button shortly appears, however, that's not too bad, shows a but what happens :) i would change that only if it is really easy to do with a line of code and no other issues opened.

@zeitschlag zeitschlag self-assigned this Jul 11, 2024
@zeitschlag zeitschlag requested a review from r10s July 11, 2024 15:30
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, so far. thanks a lot, not testing ... but it can already be merged :)

@zeitschlag zeitschlag merged commit d236a0a into main Jul 12, 2024
1 check passed
@zeitschlag zeitschlag deleted the 2129-scrolling branch July 12, 2024 07:54
@zeitschlag zeitschlag mentioned this pull request Jul 16, 2024
@r10s r10s added the bug label Jul 16, 2024
@zeitschlag zeitschlag added this to the 1.46.8 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scroll down on-sent missing sometimes
2 participants