Skip to content

Commit

Permalink
Fix/next build (#108)
Browse files Browse the repository at this point in the history
* chore: update ts config

* fix: possibly undefined value

* chore: add changeset
  • Loading branch information
moritzkirstein authored Mar 27, 2024
1 parent 50b45dc commit 3e8b148
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
7 changes: 7 additions & 0 deletions .changeset/eleven-pans-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@deltadao/nautilus": patch
---

Fix error in next build
- Fixes an error with starting compute jobs
- Fixes `tslib` dependency issues
6 changes: 5 additions & 1 deletion src/compute/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ export async function compute(computeConfig: ComputeConfig) {
)

const assetIdentifiers = [datasetConfig, algorithmConfig]
for (const dataset of additionalDatasetsConfig) assetIdentifiers.push(dataset)

// add additional datasets to identifiers, if they are set
if (additionalDatasetsConfig)
for (const dataset of additionalDatasetsConfig)
assetIdentifiers.push(dataset)

try {
// 1. Get all assets and access details from DIDs
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
// Incremental builds
// NOTE: Enabling incremental builds speeds up `tsc`.
// Keep in mind though that it does not reliably bust the cache when the `tsconfig.json` file changes.
"incremental": true,
// "incremental": true,

// Type checking
// TODO: strict is preferred. Needs some code refactoring.
Expand All @@ -42,7 +42,7 @@
// "allowSyntheticDefaultImports": false,
"forceConsistentCasingInFileNames": true,
// "verbatimModuleSyntax": true, // TODO: should be enabled, but requires some refactoring.
"importHelpers": true, // This is only used for build validation. Since we do not have `tslib` installed, this will fail if we accidentally make use of anything that'd require injection of helpers.
// "importHelpers": true , // TODO: this can be turned on for build validation. Since we do not have `tslib` installed, this will fail if we accidentally make use of anything that'd require injection of helpers.

// Language and environment
// "moduleResolution": "NodeNext",
Expand Down

0 comments on commit 3e8b148

Please sign in to comment.