[DO NOT MERGE] Python connector kernel integration for CDF reads prototype #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickJin-db
changed the title
PatrickJin-db
force-pushed
the
PatrickJin-db/python-delta-kernel-cdf_prototype
branch
from
737d42e to
86319f3
Compare
PatrickJin-db
force-pushed
the
PatrickJin-db/python-delta-kernel-cdf_prototype
branch
from
86319f3 to
c401e39
Compare
linzhou-db
reviewed
Dec 7, 2024
There was a problem hiding this comment.
overall looks good!
The next steps:
- what's the plan for unit test? is there a way to unit test without support delta format sharing in the oss server cdf?
- what's a list of tables we want to test?
- what's the largest table we want to test on?
- what's the release plan?
python/delta_sharing/reader.py
Outdated
| # Construct map from version to actions that took place in that version | ||
| for line in lines: | ||
| line_json = loads(line) | ||
| file = line_json["file"] |
There was a problem hiding this comment.
there could be metadata in lines, that needs to be handled.
https://github.com/delta-io/delta-sharing/blob/main/PROTOCOL.md#metadata-in-delta-format
PatrickJin-db
force-pushed
the
PatrickJin-db/python-delta-kernel-cdf_prototype
branch
from
8749e73 to
ae1bdef
Compare
PatrickJin-db
force-pushed
the
PatrickJin-db/python-delta-kernel-cdf_prototype
branch
from
ae1bdef to
2b96cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues:
Timestamps may be incorrect, this is an issue with the cdf_prototype branch of delta-kernel-rs.
Tested via the following:
cargo update && maturin developinpython/delta-kernel-rust-sharing-wrapperpip install .inpythonload_table_changes_as_pandascalls, using both versions and timestamps. For more details, see the script on slack.Added some unit and integration tests too