-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metadata for reader\writer features #1754
feat: add metadata for reader\writer features #1754
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer the approach with enums in #1755, though this is fine.
for feature in new_state.reader_features.iter() { | ||
self.reader_features.insert(feature.to_owned()); | ||
} | ||
|
||
for feature in new_state.writer_features.iter() { | ||
self.writer_features.insert(feature.to_owned()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear to me why we should take the union, and not just adopt the latest set of features. This would mean you could never drop features, right?
Ok, then should I abondon this one ? |
Abondoning.... |
Description
Rust client should be able to understand if given table contains any reader\writer features
Use case
Given delta file that was written by other client (possibly a more advanced one), try to understand if it requres any of the advanced features that might be specified in reader\writer features section of the protocol
Documentation
https://github.com/delta-io/delta/blob/master/PROTOCOL.md#protocol-evolution