feat: add metadata for reader\writer features #1754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbrichko
requested review from
wjones127,
roeap and
rtyler
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
michaelbrichko
changed the title
michaelbrichko
changed the title
michaelbrichko
changed the title
|
Please review. |
wjones127
reviewed
Oct 31, 2023
Comment on lines
+305
to
+311
| for feature in new_state.reader_features.iter() { | ||
| self.reader_features.insert(feature.to_owned()); | ||
| } | ||
|
|
||
| for feature in new_state.writer_features.iter() { | ||
| self.writer_features.insert(feature.to_owned()); | ||
| } |
There was a problem hiding this comment.
It's unclear to me why we should take the union, and not just adopt the latest set of features. This would mean you could never drop features, right?
Ok, then should I abondon this one ? |
|
Abondoning.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rust client should be able to understand if given table contains any reader\writer features
Use case
Given delta file that was written by other client (possibly a more advanced one), try to understand if it requres any of the advanced features that might be specified in reader\writer features section of the protocol
Documentation
https://github.com/delta-io/delta/blob/master/PROTOCOL.md#protocol-evolution