Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make find_files public #1560

Merged
merged 4 commits into from
Jul 27, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions rust/src/delta_datafusion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,9 @@ impl TreeNodeVisitor for FindFilesExprProperties {
}
}

pub(crate) struct FindFiles {
/// Representing the result of the [find_files] function.
pub struct FindFiles {
/// A list of `Add` objects that match the given predicate
pub candidates: Vec<Add>,
/// Was a physical read to the datastore required to determine the candidates
pub partition_scan: bool,
Expand Down Expand Up @@ -1289,7 +1291,8 @@ pub(crate) async fn scan_memory_table(
join_batches_with_add_actions(batches, map)
}

pub(crate) async fn find_files<'a>(
/// Finds files in a snapshot that match the provided predicate.
pub async fn find_files<'a>(
snapshot: &DeltaTableState,
object_store: ObjectStoreRef,
schema: Arc<ArrowSchema>,
Expand Down
Loading