Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add UUID statistics handling #1484

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

atefsaw
Copy link
Contributor

@atefsaw atefsaw commented Jun 21, 2023

Description

This PR adds support for calculating statistics of FixedLenByteArray UUID columns.

Related Issue(s)

Documentation

Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for submitting this!

Approved conditional on CI passing.

@atefsaw
Copy link
Contributor Author

atefsaw commented Jun 25, 2023

Hi @wjones127 , can you please re-run the actions?

@atefsaw
Copy link
Contributor Author

atefsaw commented Jun 27, 2023

Hi @wjones127 , can you please re-run the actions?

Hi @wjones127 , sorry if this is a simple question but I am new to contributing to this project and don't know why my python_build keeps failing (I don't see how it's related to my changes). can you please advise on how to resolve this build failure?
Thanks!

@wjones127
Copy link
Collaborator

Details

Don't worry about that one. Looks like it was an upgrade in mypy.

@wjones127 wjones127 enabled auto-merge (squash) June 27, 2023 14:52
@wjones127 wjones127 force-pushed the feature/add-uuid-stats-handling branch from e8d14e3 to d1f1530 Compare June 28, 2023 21:05
@wjones127 wjones127 merged commit 87c68e3 into delta-io:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FixedLenByteArray UUID statistics as a logical scalar
2 participants