Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): expose z-order in Python #1443

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

wjones127
Copy link
Collaborator

Description

Updated the API to:

DeltaTable.optimize.compact()
DeltaTable.optimize.z_order()

The old API of DeltaTable.optimize() still works, but now issues a deprecation warning.

Related Issue(s)

Documentation

@github-actions github-actions bot added binding/python Issues for the Python package documentation Improvements or additions to documentation labels Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@wjones127 wjones127 changed the title Expose Z-order in Python feat(python): expose z-order in Python Jun 6, 2023
roeap
roeap previously approved these changes Jun 6, 2023
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left one minor comment, and Sphinx seems to want mew type definitions in the pyi file.


def __call__(
self,
partition_filters: Optional[List[Tuple[str, str, Any]]] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this type in various places, what do you think about aliasing this to maybe PartitionFilters?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We had already written the type in a previous PR.

@wjones127 wjones127 requested a review from roeap June 7, 2023 02:14
Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wjones127 wjones127 merged commit 5dc89b3 into delta-io:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose Z-order in Python
2 participants