Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double url encode of partition key #1324

Merged
merged 1 commit into from
May 3, 2023
Merged

fix: double url encode of partition key #1324

merged 1 commit into from
May 3, 2023

Conversation

mrjoe7
Copy link
Contributor

@mrjoe7 mrjoe7 commented May 1, 2023

Description

This PR is fixing #1228.

Related Issue(s)

@github-actions github-actions bot added binding/rust Issues for the Rust crate rust labels May 1, 2023
@github-actions
Copy link

github-actions bot commented May 1, 2023

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@rtyler rtyler marked this pull request as draft May 1, 2023 23:08
@mrjoe7 mrjoe7 changed the title [WIP] Fix for #1228 Fixing double url encode of partition key (#1228) May 2, 2023
@mrjoe7 mrjoe7 changed the title Fixing double url encode of partition key (#1228) fix: double url encode of partition key May 2, 2023
@mrjoe7 mrjoe7 marked this pull request as ready for review May 2, 2023 23:17
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying the cause of this issue. Added a few suggestions.

rust/src/storage/utils.rs Outdated Show resolved Hide resolved
rust/src/storage/utils.rs Outdated Show resolved Hide resolved
rust/src/storage/utils.rs Show resolved Hide resolved
@wjones127 wjones127 merged commit 6b66455 into delta-io:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants