chore: add deprecation notices for commit logic on DeltaTable
#1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
rtyler and
mosyp
as code owners
roeap
force-pushed
the
commit-deprecation
branch
2 times, most recently
from
f1c28d4
to
174b6a7
Compare
roeap
commented
May 2, 2023
Comment on lines
+756
to
+766
| let configuration = configuration | ||
| .unwrap_or_default() | ||
| .into_iter() | ||
| .filter_map(|(key, value)| { | ||
| if let Ok(key) = DeltaConfigKey::from_str(&key) { | ||
| Some((key, value)) | ||
| } else { | ||
| None | ||
| } | ||
| }) | ||
| .collect(); |
There was a problem hiding this comment.
Not quite sure how we want to handle table configuration vs. metadata. With this change only known configuration can be passed to delta table, but as of right now there is no way to pass in metadata. First question would be how we want to deal with invalid config. While the code just silently ignores it, I am starting to lean towards raising an error instead. For metadata we would need to introduce a new parameter.
rtyler
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have a decent test coverage to the low-level commit logic in the transactions module, we should deprecate the commit logic exposed directly on
DeltaTable.In some places I also updated internal call sites, however did not go through all of them.
Related Issue(s)
Documentation