Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local file path in CreateBuilder::with_location() #998

Closed
wjones127 opened this issue Dec 6, 2022 · 0 comments · Fixed by #1065
Closed

Support local file path in CreateBuilder::with_location() #998

wjones127 opened this issue Dec 6, 2022 · 0 comments · Fixed by #1065
Labels
enhancement New feature or request

Comments

@wjones127
Copy link
Collaborator

Description

It would be nice to support local and relative paths without the file:// scheme prefix. They could be transformed into a fully qualified URI internally.

Use Case

Related Issue(s)

@wjones127 wjones127 added the enhancement New feature or request label Dec 6, 2022
roeap added a commit that referenced this issue Jan 15, 2023
# Description

This PR contains some improvements and refactoring for handling storage
locations.

- Removes the `StorageLocation` struct (a left-over from previous clean
up)
- allows for creating tables using local file paths (including relative)
- persists options during serialization (this will not work for custom
storage backends, but still extends what the previous approach could do)
- adopts `PrefixObjectStore` from upstream crate in favour of
maintaining that logic here.
- run `cargo clippy --fix` on `/rust`

# Related Issue(s)

Closes #998

# Documentation

<!---
Share links to useful documentation
--->
chitralverma pushed a commit to chitralverma/delta-rs that referenced this issue Mar 17, 2023
# Description

This PR contains some improvements and refactoring for handling storage
locations.

- Removes the `StorageLocation` struct (a left-over from previous clean
up)
- allows for creating tables using local file paths (including relative)
- persists options during serialization (this will not work for custom
storage backends, but still extends what the previous approach could do)
- adopts `PrefixObjectStore` from upstream crate in favour of
maintaining that logic here.
- run `cargo clippy --fix` on `/rust`

# Related Issue(s)

Closes delta-io#998

# Documentation

<!---
Share links to useful documentation
--->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant