Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decimal primitive type to document #1280

Closed
ognis1205 opened this issue Apr 13, 2023 · 3 comments · Fixed by #1281
Closed

Add decimal primitive type to document #1280

ognis1205 opened this issue Apr 13, 2023 · 3 comments · Fixed by #1281
Labels
enhancement New feature or request

Comments

@ognis1205
Copy link
Contributor

Description

According to this PR, I think that the official document should describe the decimal primitive type as well.
@ognis1205 ognis1205 added the enhancement New feature or request label Apr 13, 2023
@ognis1205
Copy link
Contributor Author

If you don't mind, I think I can handle it and make a PR.

@roeap
Copy link
Collaborator

roeap commented Apr 13, 2023

we are always happy to review and accept PRs - so any contribution highly welcome!

@ognis1205
Copy link
Contributor Author

@roeap Thanks for the comment!
Okay, after reading contribution guideline, I will work on it and make a PR.

@ognis1205 ognis1205 mentioned this issue Apr 13, 2023
Merged
wjones127 pushed a commit that referenced this issue Apr 14, 2023
@ognis1205
Add description of decimal primitive to SchemaDataType (#1281)
216fc85 
# Description
Add description of `decimal` primitive into the documentation comment of
`schema::SchemaDataType`

# Related Issue(s)
- closes #1280 

# Documentation

[schema::SchemaDataType](https://docs.rs/deltalake/latest/deltalake/schema/enum.SchemaDataType.html)

Signed-off-by: Shingo OKAWA <shingo.okawa.g.h.c@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add description of decimal primitive to SchemaDataType ognis1205/delta-rs
2 participants
@ognis1205 @roeap