Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cargo.lock from library crates and add Cargo.lock to binary ones #1000

Closed
Tracked by #971
iajoiner opened this issue Dec 7, 2022 · 0 comments · Fixed by #1001
Closed
Tracked by #971

Remove Cargo.lock from library crates and add Cargo.lock to binary ones #1000

iajoiner opened this issue Dec 7, 2022 · 0 comments · Fixed by #1001
Labels
enhancement New feature or request

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Dec 7, 2022

Description

According to the following document https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries it is good practice to commit Cargo.lock in binary crates and not commit it in library ones. Currently we are not following the best practices as mentioned and need to fix it.
@iajoiner iajoiner added the enhancement New feature or request label Dec 7, 2022
@iajoiner iajoiner mentioned this issue Dec 7, 2022
Merged
wjones127 pushed a commit that referenced this issue Dec 7, 2022
@iajoiner
Update .gitignore and add/remove Cargo.lock when appropriate (#1001)
c1f5a7e 
# Description
1. Add to `.gitignore` so that all `Cargo.lock` files except for the
ones in the listed binary crates are ignored.
2. Add `Cargo.lock` to the proofs crate since it is binary.
3. Remove `Cargo.lock` from the root directory.

# Related Issue(s)
Closes #1000
@iajoiner iajoiner mentioned this issue Dec 8, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update .gitignore and add/remove Cargo.lock when appropriate iajoiner/delta-rs
1 participant
@iajoiner