Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zio command should also show any I/Os which are in the DONE stage #343

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

grwilson
Copy link
Contributor

No description provided.

@grwilson grwilson changed the title zio command should also show any I/O which are in the DONE stage zio command should also show any I/Os which are in the DONE stage Nov 10, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16267f9) 85.21% compared to head (ff5c520) 84.45%.

❗ Current head ff5c520 differs from pull request most recent head d3cd88f. Consider uploading reports for the commit d3cd88f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #343      +/-   ##
===========================================
- Coverage    85.21%   84.45%   -0.76%     
===========================================
  Files           67       67              
  Lines         3070     3068       -2     
===========================================
- Hits          2616     2591      -25     
- Misses         454      477      +23     
Files Coverage Δ
sdb/commands/zfs/zio.py 85.29% <ø> (-7.57%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why we originally hit them? should we have a flag to show/hide them? just curious if we're regressing in some workflow; e.g. maybe there's "too many" in the "done" stage, making it more difficult to see the non-done IOs?

change LGTM, but I'm not sure I'm experienced enough to say if there'll be any adverse affects to this change or not.

we don't need to update any of the test cases? if not, perhaps that means we should add some tests for this command....

@grwilson
Copy link
Contributor Author

I think the assumption was that a "DONE" zio is not relevant but if it's still around it may be calling a done func and you may want to be able to track down what it's doing. I don't see any reason why you wouldn't want to show it.

@prakashsurya
Copy link
Contributor

cool, OK.. that makes sense to me.

@grwilson grwilson merged commit 92fc92b into delphix:develop Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants