Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOL-16649 CONFIG_MD is needed on the buildserver #22

Merged
merged 1 commit into from
Nov 10, 2022
Merged

TOOL-16649 CONFIG_MD is needed on the buildserver #22

merged 1 commit into from
Nov 10, 2022

Conversation

prakashsurya
Copy link

@prakashsurya prakashsurya commented Nov 10, 2022 •
edited
Loading

kpartx fails without this change when running appliance-build on a Delphix buildserver:

15:49:37  ++ kpartx -asv internal-qa-gcp.img
15:49:37  ++ head -n1
15:49:37  ++ awk '{ print $3 }'
15:49:37  ++ sed 's/^\(loop[0-9]\+\)p[0-9]\+$/\1/'
15:49:37  /dev/mapper/control: open failed: No such device
15:49:37  Failure to communicate with kernel device-mapper driver.
15:49:37  Check that device-mapper is available in the kernel.
15:49:37  Incompatible libdevmapper 1.02.167 (2019-11-30) and kernel driver (unknown version).
15:49:37  device mapper prerequisites not met
  • git-ab-pre-push -v internal-buildserver --no-tests is here

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/c909b7cc-5f29-4604-a893-3f537ac36224 branch from 5fde477 to 807625e Compare November 10, 2022 16:12
@prakashsurya
Copy link
Author

I verified the buildserver has the necessary config option with this change:

$ cat /boot/config-5.4.0-1088-dx2022111016-807625ed5-aws | grep BLK_DEV_MD
CONFIG_BLK_DEV_MD=y

@prakashsurya prakashsurya marked this pull request as ready for review November 10, 2022 20:36
@prakashsurya prakashsurya enabled auto-merge (squash) November 10, 2022 20:39
@prakashsurya prakashsurya merged commit 1805e5d into 6.0/stage Nov 10, 2022
@prakashsurya prakashsurya deleted the dlpx/pr/prakashsurya/c909b7cc-5f29-4604-a893-3f537ac36224 branch November 10, 2022 21:52
delphix-devops-bot pushed a commit that referenced this pull request Nov 17, 2022
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
f9eba99
delphix-devops-bot pushed a commit that referenced this pull request Nov 18, 2022
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
9c48035
delphix-devops-bot pushed a commit that referenced this pull request Dec 15, 2022
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
88890cb
delphix-devops-bot pushed a commit that referenced this pull request Jan 7, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
67210b9
delphix-devops-bot pushed a commit that referenced this pull request Jan 16, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
49225bf
delphix-devops-bot pushed a commit that referenced this pull request Feb 10, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
1a81161
delphix-devops-bot pushed a commit that referenced this pull request Mar 4, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
dac5f87
prakashsurya pushed a commit that referenced this pull request Mar 11, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
564fad6
prakashsurya pushed a commit that referenced this pull request Mar 14, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
f046c48
prakashsurya pushed a commit that referenced this pull request Mar 14, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
42614cb
delphix-devops-bot pushed a commit that referenced this pull request Mar 30, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
04c0cb2
delphix-devops-bot pushed a commit that referenced this pull request Apr 20, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
a8c8edf
delphix-devops-bot pushed a commit that referenced this pull request Apr 28, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
d5521fc
delphix-devops-bot pushed a commit that referenced this pull request May 31, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
eaf6d94
delphix-devops-bot pushed a commit that referenced this pull request Jun 3, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
5526bd5
delphix-devops-bot pushed a commit that referenced this pull request Jun 4, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
24ab726
delphix-devops-bot pushed a commit that referenced this pull request Jun 5, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
3431a35
prakashsurya pushed a commit that referenced this pull request Aug 8, 2023
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
179c986
delphix-devops-bot pushed a commit that referenced this pull request Aug 16, 2023
@sassmann @smb49
iavf: fix hang on reboot with ice
65912a1 
BugLink: https://bugs.launchpad.net/bugs/2023230

[ Upstream commit 4e264be ]

When a system with E810 with existing VFs gets rebooted the following
hang may be observed.

 Pid 1 is hung in iavf_remove(), part of a network driver:
 PID: 1        TASK: ffff965400e5a340  CPU: 24   COMMAND: "systemd-shutdow"
  #0 [ffffaad04005fa50] __schedule at ffffffff8b3239cb
  #1 [ffffaad04005fae8] schedule at ffffffff8b323e2d
  #2 [ffffaad04005fb00] schedule_hrtimeout_range_clock at ffffffff8b32cebc
  #3 [ffffaad04005fb80] usleep_range_state at ffffffff8b32c930
  #4 [ffffaad04005fbb0] iavf_remove at ffffffffc12b9b4c [iavf]
  #5 [ffffaad04005fbf0] pci_device_remove at ffffffff8add7513
  #6 [ffffaad04005fc10] device_release_driver_internal at ffffffff8af08baa
  #7 [ffffaad04005fc40] pci_stop_bus_device at ffffffff8adcc5fc
  #8 [ffffaad04005fc60] pci_stop_and_remove_bus_device at ffffffff8adcc81e
  #9 [ffffaad04005fc70] pci_iov_remove_virtfn at ffffffff8adf9429
 #10 [ffffaad04005fca8] sriov_disable at ffffffff8adf98e4
 #11 [ffffaad04005fcc8] ice_free_vfs at ffffffffc04bb2c8 [ice]
 #12 [ffffaad04005fd10] ice_remove at ffffffffc04778fe [ice]
 #13 [ffffaad04005fd38] ice_shutdown at ffffffffc0477946 [ice]
 #14 [ffffaad04005fd50] pci_device_shutdown at ffffffff8add58f1
 #15 [ffffaad04005fd70] device_shutdown at ffffffff8af05386
 #16 [ffffaad04005fd98] kernel_restart at ffffffff8a92a870
 #17 [ffffaad04005fda8] __do_sys_reboot at ffffffff8a92abd6
 #18 [ffffaad04005fee0] do_syscall_64 at ffffffff8b317159
 #19 [ffffaad04005ff08] __context_tracking_enter at ffffffff8b31b6fc
 #20 [ffffaad04005ff18] syscall_exit_to_user_mode at ffffffff8b31b50d
 #21 [ffffaad04005ff28] do_syscall_64 at ffffffff8b317169
 #22 [ffffaad04005ff50] entry_SYSCALL_64_after_hwframe at ffffffff8b40009b
     RIP: 00007f1baa5c13d7  RSP: 00007fffbcc55a98  RFLAGS: 00000202
     RAX: ffffffffffffffda  RBX: 0000000000000000  RCX: 00007f1baa5c13d7
     RDX: 0000000001234567  RSI: 0000000028121969  RDI: 00000000fee1dead
     RBP: 00007fffbcc55ca0   R8: 0000000000000000   R9: 00007fffbcc54e90
     R10: 00007fffbcc55050  R11: 0000000000000202  R12: 0000000000000005
     R13: 0000000000000000  R14: 00007fffbcc55af0  R15: 0000000000000000
     ORIG_RAX: 00000000000000a9  CS: 0033  SS: 002b

During reboot all drivers PM shutdown callbacks are invoked.
In iavf_shutdown() the adapter state is changed to __IAVF_REMOVE.
In ice_shutdown() the call chain above is executed, which at some point
calls iavf_remove(). However iavf_remove() expects the VF to be in one
of the states __IAVF_RUNNING, __IAVF_DOWN or __IAVF_INIT_FAILED. If
that's not the case it sleeps forever.
So if iavf_shutdown() gets invoked before iavf_remove() the system will
hang indefinitely because the adapter is already in state __IAVF_REMOVE.

Fix this by returning from iavf_remove() if the state is __IAVF_REMOVE,
as we already went through iavf_shutdown().

Fixes: 9745780 ("iavf: Add waiting so the port is initialized in remove")
Fixes: a841733 ("iavf: Fix race condition between iavf_shutdown and iavf_remove")
Reported-by: Marius Cornea <mcornea@redhat.com>
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>
delphix-devops-bot pushed a commit that referenced this pull request Aug 15, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
ed5c40e
delphix-devops-bot pushed a commit that referenced this pull request Aug 22, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
54232c0
delphix-devops-bot pushed a commit that referenced this pull request Aug 23, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
ead1b4b
prakashsurya pushed a commit that referenced this pull request Sep 23, 2024
@prakashsurya
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
53ec2af
delphix-devops-bot pushed a commit that referenced this pull request Oct 20, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
305c8df
delphix-devops-bot pushed a commit that referenced this pull request Oct 21, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
0bb465e
palash-gandhi pushed a commit that referenced this pull request Oct 24, 2024
@palash-gandhi
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
0768aea
@palash-gandhi palash-gandhi mentioned this pull request Oct 24, 2024
Merged
delphix-devops-bot pushed a commit that referenced this pull request Nov 10, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
919917e
delphix-devops-bot pushed a commit that referenced this pull request Dec 18, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
a0fccf8
delphix-devops-bot pushed a commit that referenced this pull request Dec 19, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
d426384
delphix-devops-bot pushed a commit that referenced this pull request Dec 20, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
a450b87
delphix-devops-bot pushed a commit that referenced this pull request Dec 21, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
8b76698
delphix-devops-bot pushed a commit that referenced this pull request Dec 22, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
cfc2099
delphix-devops-bot pushed a commit that referenced this pull request Dec 23, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
d56af76
delphix-devops-bot pushed a commit that referenced this pull request Dec 24, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
5b9cf89
delphix-devops-bot pushed a commit that referenced this pull request Dec 25, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
bcf95db
delphix-devops-bot pushed a commit that referenced this pull request Dec 26, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
3151e5c
delphix-devops-bot pushed a commit that referenced this pull request Dec 27, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
76ef0cb
delphix-devops-bot pushed a commit that referenced this pull request Dec 28, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
9780b35
delphix-devops-bot pushed a commit that referenced this pull request Dec 29, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
59c4ca6
delphix-devops-bot pushed a commit that referenced this pull request Dec 30, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
8ae291e
delphix-devops-bot pushed a commit that referenced this pull request Dec 31, 2024
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
855156c
delphix-devops-bot pushed a commit that referenced this pull request Jan 1, 2025
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
b44730c
delphix-devops-bot pushed a commit that referenced this pull request Jan 2, 2025
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
034088b
delphix-devops-bot pushed a commit that referenced this pull request Jan 3, 2025
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
165e3f6
delphix-devops-bot pushed a commit that referenced this pull request Jan 4, 2025
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
64e6289
delphix-devops-bot pushed a commit that referenced this pull request Jan 5, 2025
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
21c7161
delphix-devops-bot pushed a commit that referenced this pull request Jan 7, 2025
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
c4fa697
delphix-devops-bot pushed a commit that referenced this pull request Feb 12, 2025
TOOL-16649 CONFIG_MD is needed on the buildserver (#22)
06a97ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebroy sebroy sebroy approved these changes

@sdimitro sdimitro sdimitro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prakashsurya @sebroy @sdimitro