Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 3.5 support #219

Closed
goodmami opened this issue May 10, 2019 · 1 comment
Closed

Remove Python 3.5 support #219

goodmami opened this issue May 10, 2019 · 1 comment
Labels
maintenance improving code quality; not features or bugs
Milestone
v1.2.0

Comments

@goodmami
Copy link
Member

This issue is for collecting the compromises made to accommodate Python 3.5, and opportunities for new features. It is not (yet) slated for a particular release.
@goodmami
Copy link
Member Author

goodmami commented Jul 4, 2019 •
edited
Loading

Another benefit: pytest's tmp_path fixture returns a normal pathlib.Path instead of 3rd party py.path.local or pathlib2.Path object (which causes some headaches when unit testing with Python 3.5)

edit: And another: PEP-526 type annotations on variables

@goodmami goodmami mentioned this issue Jul 4, 2019
Closed
@goodmami goodmami added the maintenance improving code quality; not features or bugs label Aug 16, 2019
goodmami added a commit that referenced this issue Jan 9, 2020
@goodmami
Replace REPP namedtuples with typing.NamedTuples
d560894 
Part of #219
goodmami added a commit that referenced this issue Jan 9, 2020
@goodmami
Replace token namedtuples with typing.NamedTuples
1c7876a 
Unfortunately I could not get rid of the need for a wrapper class due
to the instantiation checks that don't comply with standard Python
semantics.

Part of #219
goodmami added a commit that referenced this issue Jan 9, 2020
@goodmami
Convert type comments to PEP-526 annotations
c66d298 
Part of #219
goodmami added a commit that referenced this issue Jan 9, 2020
@goodmami
Replace str.format() with f-strings where obvious
02205d4 
If it made the code more legible, they were replaced.

Part of #219
goodmami added a commit that referenced this issue Jan 10, 2020
@goodmami
Remove unnecessary casts of Path objects to str
c7b992d 
More standard library functions accept Path objects as of Python 3.6.

Part of #219
@goodmami goodmami added this to the v1.2.0 milestone Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance improving code quality; not features or bugs
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@goodmami