Writable Snapshot DataSource Added #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakshi-dell
requested review from
shenda1,
forrestxia,
baoy1,
taohe1012,
P-Cao,
tanh17,
doriac11,
nikitajoshi1,
shekhar-j,
RayLiu7,
vangork,
sapana05,
MangirishK,
Krunal-Thakkar and
rounak-adhikary
as code owners
Sakshi-dell
changed the title
|
run e2e test WritableSnapshotDatasource |
shenda1
reviewed
Oct 23, 2024
| "id": schema.StringAttribute{ | ||
| Optional: true, | ||
| Computed: true, | ||
| Description: "Path of the writable snapshot.", |
shenda1
reviewed
Oct 23, 2024
| MarkdownDescription: "Writable Snapshot state.", | ||
| Validators: []validator.String{ | ||
| stringvalidator.OneOf( | ||
| "active", |
There was a problem hiding this comment.
Do we need validator for computed attribute?
shenda1
reviewed
Oct 23, 2024
| } | ||
| data "powerscale_writable_snapshot" "test" { | ||
| filter { | ||
| path = data.powerscale_writable_snapshot.preq.writable[0].dst_path |
There was a problem hiding this comment.
Can we create this pre-req on fly?
There was a problem hiding this comment.
Added writableSnapshotResourceConfig
|
run e2e test WritableSnapshotDatasource |
shenda1
approved these changes
Oct 23, 2024
rounak-adhikary
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Writable Snapshot datasource added
GitHub Issues
List the GitHub issues impacted by this PR:
ISSUE TYPE
RESOURCE OR DATASOURCE NAME
Writable_Snapshot Datasource
OUTPUT
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration