Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bugs for support assist resource #211

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

shenda1
Copy link
Contributor

@shenda1 shenda1 commented Sep 19, 2024

Description

PR is raised to fix the bugs for support assist resource

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME

support_assist

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

Signed-off-by: Shendge <akash.shendge@dell.com>
@shenda1
Copy link
Contributor Author

shenda1 commented Sep 19, 2024

run e2e test SupportAssistResource

@shenda1
Copy link
Contributor Author

shenda1 commented Sep 19, 2024

run e2e test SupportAssistResource

Copy link
Contributor

@Krishnan-Priyanshu Krishnan-Priyanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the support assist fix
LGTM

@Krishnan-Priyanshu Krishnan-Priyanshu merged commit ff09de6 into main Sep 19, 2024
7 checks passed
@Krishnan-Priyanshu Krishnan-Priyanshu deleted the support-assist-bugfix branch September 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants