-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access Zone Datasource #2
Conversation
d93ad6d
to
9dd3395
Compare
run e2e test |
Hi @doriac11 The generated openapi code is using int32 for all integers, but it cannot meet our needs, for example
How can we handle that issue? And as we discussed before, generating with int64 will cause error. |
@shekhar-j lowered the max values for these so we could generate the code (it is in the zip file in the PR). We can use this for now and in the meantime (to extract use |
@NavisJ If you all review and approve this PR we can merge it so you all have a baseline with the client code to work from. |
The overall workflow looks good to me. But the type issue blocks the development of cluster datasource. error is like
Manually change the type can resolve the issue. Can we manually change the type and rezip the code for now? |
|
9dd3395
to
b931832
Compare
b931832
to
9224393
Compare
run e2e test |
3 similar comments
run e2e test |
run e2e test |
run e2e test |
@doriac11 gosec check has failure And please do the local checks defined in the Makefile and ensure they all pass before raising PR. Sample local check command line is like this: |
@forrestxia Should we make a pipeline step for gosec, I made sure I was passing all of the other tests before raising, I didnt realize gosec was a test. Will make the changes now |
5150c54
9224393
to
5150c54
Compare
@forrestxia , thanks for bringing these to the attention! |
run e2e test |
gosec check was integrated in "Build" stage of terraform pipeline since the beginning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5150c54
to
c03b61f
Compare
@forrestxia I added 2 more tests and now I am at 84%. |
c03b61f
to
b43f96f
Compare
run e2e test |
Description
Read Access Zone Datasource using an OpenAPI Client
ISSUE TYPE
RESOURCE OR DATASOURCE NAME
Access Zone Datasource
OUTPUT
Apply, Plan and Destroy
ADDITIONAL INFORMATION
Tests
``
TF_ACC=1 go test -v -run TestAccAccessZoneDataSourceAll
=== RUN TestAccAccessZoneDataSourceAll
provider_test.go:86:
provider "powerscale" {
username = "user"
password = "pass"
endpoint = "https://xxxx:8080"
insecure = true
group = ""
volume_path = ""
volume_path_permissions = ""
ignore_unresolvable_hosts = "true"
auth_type = "0"
verbose_logging = "0"
}
config {Host: Scheme: DefaultHeader:map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8] UserAgent:terraform-powermax-provider/1.0.0 Debug:false Servers:[{URL:https://10.225.108.6:8080 Description:https://10.225.108.6:8080 Variables:map[]}] OperationServers:map[] HTTPClient:0xc00032a120} header map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8]config {Host: Scheme: DefaultHeader:map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8] UserAgent:terraform-powermax-provider/1.0.0 Debug:false Servers:[{URL:https://10.225.108.6:8080 Description:https://10.225.108.6:8080 Variables:map[]}] OperationServers:map[] HTTPClient:0xc000516360} header map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8]config {Host: Scheme: DefaultHeader:map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8] UserAgent:terraform-powermax-provider/1.0.0 Debug:false Servers:[{URL:https://10.225.108.6:8080 Description:https://10.225.108.6:8080 Variables:map[]}] OperationServers:map[] HTTPClient:0xc00023a5a0} header map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8]config {Host: Scheme: DefaultHeader:map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8] UserAgent:terraform-powermax-provider/1.0.0 Debug:false Servers:[{URL:https://10.225.108.6:8080 Description:https://10.225.108.6:8080 Variables:map[]}] OperationServers:map[] HTTPClient:0xc0002bf260} header map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8]config {Host: Scheme: DefaultHeader:map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8] UserAgent:terraform-powermax-provider/1.0.0 Debug:false Servers:[{URL:https://10.225.108.6:8080 Description:https://10.225.108.6:8080 Variables:map[]}] OperationServers:map[] HTTPClient:0xc0005175f0} header map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8]config {Host: Scheme: DefaultHeader:map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8] UserAgent:terraform-powermax-provider/1.0.0 Debug:false Servers:[{URL:https://10.225.108.6:8080 Description:https://10.225.108.6:8080 Variables:map[]}] OperationServers:map[] HTTPClient:0xc0003a0270} header map[Accept:application/json; charset=utf-8 Content-Type:application/json; charset=utf-8]--- PASS: TestAccAccessZoneDataSourceAll (10.75s)
PASS
ok terraform-provider-powerscale/powerscale/provider 13.586s