Implement Nfs Export Resource #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-Cao
requested review from
shenda1,
forrestxia,
baoy1,
taohe1012,
tanh17,
NavisJ,
doriac11,
nikitajoshi1,
shekhar-j and
RayLiu7
as code owners
P-Cao
force-pushed
the
feature-nfs-export-resource
branch
from
559d474
to
b2bf973
Compare
|
run e2e test |
P-Cao
force-pushed
the
feature-nfs-export-resource
branch
2 times, most recently
from
2742058
to
466d255
Compare
|
run e2e test |
doriac11
reviewed
Aug 4, 2023
| }, | ||
| "write_transfer_multiple": { | ||
| "description": "Specifies the preferred multiple size for NFS write requests. This value is used to advise the client of optimal settings for the server, but is not enforced.", | ||
| "maximum": 2147483646, | ||
| "minimum": 0, | ||
| "type": "integer" | ||
| "type": "integer", |
There was a problem hiding this comment.
Could you also relay the changes you had to make here: https://confluence.cec.lab.emc.com/display/TFM/PowerScale+OpenAPI+Changes+and+Found+Issues in the OpenAPI json?
doriac11
previously approved these changes
Aug 4, 2023
nikitajoshi1
previously approved these changes
Aug 4, 2023
NavisJ
previously approved these changes
Aug 7, 2023
P-Cao
force-pushed
the
feature-nfs-export-resource
branch
from
466d255
to
5527935
Compare
|
run e2e test |
P-Cao
force-pushed
the
feature-nfs-export-resource
branch
from
5527935
to
f3327bb
Compare
|
run e2e test |
1 similar comment
|
run e2e test |
P-Cao
dismissed stale reviews from nikitajoshi1, doriac11, and NavisJ
via
8eec63c
P-Cao
force-pushed
the
feature-nfs-export-resource
branch
from
f3327bb
to
8eec63c
Compare
|
run e2e test |
forrestxia
approved these changes
Aug 7, 2023
Set openapi integer field as int64 Add NFS Export resource and AT Improve resource helper for Nullable String and Nil field
P-Cao
force-pushed
the
feature-nfs-export-resource
branch
from
8eec63c
to
43ded72
Compare
|
run e2e test |
taohe1012
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set openapi integer field as int64
Add NFS Export resource and AT
Improve resource helper for Nullable String and Nil field
GitHub Issues
List the GitHub issues impacted by this PR:
ISSUE TYPE
RESOURCE OR DATASOURCE NAME
NFS Export Resource
OUTPUT
ADDITIONAL INFORMATION
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration