Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect fixes #631

Merged
merged 13 commits into from
Mar 22, 2024
Merged

Defect fixes #631

merged 13 commits into from
Mar 22, 2024

Conversation

ShivamSh3
Copy link
Contributor

@ShivamSh3 ShivamSh3 commented Mar 11, 2024

Description

Following defects are fixed:
JIT-281593
JIT-281767
JIT-282006
JIT-282007
JIT-281758
JIT-287848

GitHub Issues

#625

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 78.69822% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 93.39%. Comparing base (960009d) to head (1847922).

Files Patch % Lines
plugins/modules/redfish_storage_volume.py 73.11% 9 Missing and 16 partials ⚠️
...nit/plugins/modules/test_redfish_storage_volume.py 91.11% 2 Missing and 2 partials ⚠️
plugins/module_utils/utils.py 84.61% 1 Missing and 1 partial ⚠️
plugins/modules/ome_devices.py 60.00% 1 Missing and 1 partial ⚠️
plugins/module_utils/dellemc_idrac.py 50.00% 1 Missing ⚠️
...ins/modules/ome_application_console_preferences.py 66.66% 1 Missing ⚠️
...odules/test_ome_application_console_preferences.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           collections     #631      +/-   ##
===============================================
- Coverage        93.43%   93.39%   -0.04%     
===============================================
  Files              197      197              
  Lines            33354    33422      +68     
  Branches          5126     5139      +13     
===============================================
+ Hits             31164    31216      +52     
- Misses            1331     1338       +7     
- Partials           859      868       +9     
Flag Coverage Δ
units 93.39% <78.69%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plugins/modules/ome_application_console_preferences.py Outdated Show resolved Hide resolved
plugins/modules/ome_device_local_access_configuration.py Outdated Show resolved Hide resolved
plugins/modules/ome_devices.py Outdated Show resolved Hide resolved
plugins/modules/ome_devices.py Outdated Show resolved Hide resolved
tests/unit/plugins/modules/test_ome_devices.py Outdated Show resolved Hide resolved
@ShivamSh3 ShivamSh3 requested a review from sachin-apa March 14, 2024 11:47
@Kritika-Bhateja-03 Kritika-Bhateja-03 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Mar 19, 2024
@sachin-apa sachin-apa added validation/in-progress Validation is in progress and removed validation/completed Validation is completed labels Mar 20, 2024
@rajshekarp87 rajshekarp87 added this to the v9.1.0 milestone Mar 21, 2024
rajshekarp87
rajshekarp87 previously approved these changes Mar 21, 2024
@Kritika-Bhateja-03 Kritika-Bhateja-03 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Mar 22, 2024
@sachin-apa sachin-apa merged commit 505a3e8 into dell:collections Mar 22, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/completed Validation is completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: redfish_storage_volume failing to create Raid 1 volume starting from collection 8.3.0
8 participants