Release 2.0.2

CHANGELOG.md

@@ -4,6 +4,22 @@ Dell EMC OpenManage Ansible Modules allows Data Center and IT administrators to
 
 With the latest release of Dell EMC OpenManage Ansible Modules, the capabilities have improved with support for OpenManage Enterprise. OpenManage Ansible Modules allows users to retrieve device inventory information of each device discovered in the OpenManage Enterprise.
 
+# 2.0.2 (September 21, 2019)
+
+  * The dellemc_ome_template module is deprecated and all the functionality are added to the new ome_template module.
+
+  * The dellemc_ome_user_facts module is deprecated and all the functionality are added to the new ome_user_info module.
+
+  * The dellemc_boot_to_network_iso module is deprecated and all the functionality are added to the new idrac_os_deployment module.
+
+  * Support custom interval (default is 18 hours) for auto-detaching an ISO image for idrac_os_deployment.
+
+  * The ome_template_info and ome_user_info modules are enhanced to filter records using name in system_query_options.
+
+  * Support to modify or deploy template using parameter template_name in ome_template module.
+
+  * Support to delete an existing user account, using name in ome_user module.
+
 # 2.0.1 (June 6, 2019)
 
   * idrac_firmware and idrac_server_config_profile modules are added.

CODING_GUIDELINES.md

@@ -0,0 +1,13 @@
+### Below are our coding guidelines 
+* Contributions should adhere to ansible Coding standard guidelines as we follow these standards.
+* Contributions are welcome only on our "devel" branch.
+* Should include integration [test](./test) scripts for your changes.
+* Few of our modules are part of ansible main project repository. Do not include those modules in your contribution request. We would like to review these contributions on ansible main project repository.
+* Do not submit a contribution request on our deprecated modules. They are just meant for backward compatibility.
+
+### Review
+* The contributions will be reviewed and feedback will be provided. This may happen for multiple cycles depending on the necessity. 
+* Once all the feedback is addressed and review committee is convinced, contribution will be accepted. The review is purely subjective.
+
+________________________________________
+All contributions must include acceptance of the [DCO](./CONTRIBUTOR_AGREEMENT.md)

CONTRIBUTOR_AGREEMENT.md

@@ -0,0 +1,18 @@
+### Contributor Agreement
+All contributions shall be made under the Developer Certification of Origin (“DCO”) (see http://elinux.org/Developer_Certificate_Of_Origin) which is reproduced below. Specifically, the Git commit message for the contribution should contain the following tag information signifying use of the DCO:
+
+
+“Signed-off-by: [Your Name] [youremail@company.com]”
+
+
+________________________________________
+#### Developer's Certificate of Origin 1.1
+By making a contribution to this project, I certify that:
+
+(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
+
+(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
+
+(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
+
+(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

README.md

@@ -45,7 +45,11 @@ python uninstall.py
 
 ## LICENSE
 This project is licensed under GPL-3.0 License. Please see the [COPYING](
-https://github.com/dell/dellemc-openmanage-ansible-modules/blob/master/COPYING.md) for more information
+./COPYING.md) for more information
+
+
+## Contributing
+We welcome your contributions to OpenManage Ansible Modules. See [Coding Guidelines](./CODING_GUIDELINES.md) for more details.
 
 ## Support
   * This devel branch corresponds to the release actively under development.

library/dellemc/idrac/dellemc_boot_to_network_iso.py → deprecated/_dellemc_boot_to_network_iso.py

@@ -14,14 +14,18 @@
 __metaclass__ = type
 
 ANSIBLE_METADATA = {'metadata_version': '1.1',
-                    'status': ['preview'],
+                    'status': ['deprecated'],
                     'supported_by': 'community'}
 
 DOCUMENTATION = """
 ---
 module: dellemc_boot_to_network_iso
 short_description: Boot to a network ISO image.
 version_added: "2.3"
+deprecated:
+  removed_in: "3.3"
+  why: Replaced with M(idrac_os_deployment).
+  alternative: Use M(idrac_os_deployment) instead.
 description: Boot to a network ISO image.
 options:
     idrac_ip:
@@ -150,7 +154,9 @@ def main():
 
         ),
         supports_check_mode=False)
-
+    module.deprecate("The 'dellemc_boot_to_network_iso' module has been deprecated. "
+                     "Use 'idrac_os_deployment' instead",
+                     version=3.3)
     try:
         with iDRACConnection(module.params) as idrac:
             msg, err = run_boot_to_network_iso(idrac, module)

library/dellemc/idrac/_dellemc_export_server_config_profile.py → deprecated/_dellemc_export_server_config_profile.py

@@ -25,7 +25,7 @@
 short_description: Export Server Configuration Profile (SCP) to a network share or to a local file.
 version_added: "2.3"
 deprecated:
-  removed_in: "2.11"
+  removed_in: "3.1"
   why: Replaced with M(dellemc_idrac_server_config_profile).
   alternative: Use M(dellemc_idrac_server_config_profile) instead.
 description:
@@ -210,7 +210,7 @@ def main():
         supports_check_mode=False)
     module.deprecate("The 'dellemc_export_server_config_profile' module has been deprecated. "
                      "Use 'dellemc_idrac_server_config_profile' instead",
-                     version=2.11)
+                     version=3.1)
 
     try:
         with iDRACConnection(module.params) as idrac:

library/dellemc/idrac/_dellemc_idrac_firmware.py → deprecated/_dellemc_idrac_firmware.py

@@ -25,7 +25,7 @@
 short_description: Firmware update from a repository on a network share (CIFS, NFS).
 version_added: "2.8"
 deprecated:
-  removed_in: "2.12"
+  removed_in: "3.2"
   why: Replaced with M(idrac_firmware).
   alternative: Use M(idrac_firmware) instead.
 description:
@@ -201,7 +201,7 @@ def main():
         supports_check_mode=False)
     module.deprecate("The 'dellemc_idrac_firmware' module has been deprecated. "
                      "Use 'idrac_firmware' instead",
-                     version=2.12)
+                     version=3.2)
 
     try:
         # Validate the catalog file

library/dellemc/idrac/_dellemc_idrac_server_config_profile.py → deprecated/_dellemc_idrac_server_config_profile.py

@@ -25,7 +25,7 @@
 short_description: Export or Import Server Configuration Profile(SCP).
 version_added: "2.8"
 deprecated:
-  removed_in: "2.12"
+  removed_in: "3.2"
   why: Replaced with M(idrac_server_config_profile).
   alternative: Use M(idrac_server_config_profile) instead.
 description:
@@ -290,7 +290,7 @@ def main():
 
     module.deprecate("The 'dellemc_server_config_profile' module has been deprecated. "
                      "Use 'idrac_server_config_profile' instead",
-                     version=2.12)
+                     version=3.2)
 
     try:
         changed = False

library/dellemc/idrac/_dellemc_import_server_config_profile.py → deprecated/_dellemc_import_server_config_profile.py

@@ -25,7 +25,7 @@
 short_description: Import SCP from a network share or from a local file.
 version_added: "2.3"
 deprecated:
-  removed_in: "2.11"
+  removed_in: "3.1"
   why: Replaced with M(dellemc_idrac_server_config_profile).
   alternative: Use M(dellemc_idrac_server_config_profile) instead.
 description:
@@ -233,7 +233,7 @@ def main():
         supports_check_mode=False)
     module.deprecate("The 'dellemc_import_server_config_profile' module has been deprecated. "
                      "Use 'dellemc_idrac_server_config_profile' instead",
-                     version=2.11)
+                     version=3.1)
     try:
         with iDRACConnection(module.params) as idrac:
             msg, err = run_import_server_config_profile(idrac, module)

library/dellemc/idrac/_dellemc_install_firmware.py → deprecated/_dellemc_install_firmware.py

@@ -25,7 +25,7 @@
 short_description: Firmware update from a repository on a network share (CIFS, NFS).
 version_added: "2.3"
 deprecated:
-  removed_in: "2.11"
+  removed_in: "3.1"
   why: Replaced with M(dellemc_idrac_firmware).
   alternative: Use M(dellemc_idrac_firmware) instead.
 description:
@@ -217,7 +217,7 @@ def main():
 
     module.deprecate("The 'dellemc_install_firmware' module has been deprecated. "
                      "Use 'dellemc_idrac_firmware' instead",
-                     version=2.11)
+                     version=3.1)
 
     try:
         with iDRACConnection(module.params) as idrac:

library/dellemc/ome/dellemc_ome_device_facts.py → deprecated/_dellemc_ome_device_facts.py

@@ -16,14 +16,18 @@
 __metaclass__ = type
 
 ANSIBLE_METADATA = {'metadata_version': '1.1',
-                    'status': ['preview'],
+                    'status': ['deprecated'],
                     'supported_by': 'community'}
 
 DOCUMENTATION = r'''
 ---
 module: dellemc_ome_device_facts
 short_description: Retrieves Device details.
 version_added: "2.8"
+deprecated:
+   removed_in: "3.2"
+   why: Replaced with M(ome_device_info).
+   alternative: Use M(ome_device_info) instead.
 description:
    - Retrieves the list of all devices with the exhaustive inventory of each
      device.
@@ -209,7 +213,7 @@
 """
 
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.remote_management.dellemc.dellemc_ome import RestOME
+from ansible.module_utils.remote_management.dellemc.ome import RestOME
 from ansible.module_utils.six.moves.urllib.error import URLError, HTTPError
 from ansible.module_utils.urls import ConnectionError, SSLValidationError
 
@@ -380,7 +384,9 @@ def main():
         required_if=[['fact_subset', 'detailed_inventory', ['system_query_options']],
                      ['fact_subset', 'subsystem_health', ['system_query_options']], ],
         supports_check_mode=False)
-
+    module.deprecate("The 'dellemc_ome_device_facts' module has been deprecated. "
+                     "Use 'ome_device_info' instead",
+                     version=3.2)
     try:
         _validate_inputs(module.params)
         with RestOME(module.params, req_session=True) as rest_obj:

library/dellemc/ome/dellemc_ome_template.py → deprecated/_dellemc_ome_template.py

@@ -16,14 +16,18 @@
 __metaclass__ = type
 
 ANSIBLE_METADATA = {'metadata_version': '1.1',
-                    'status': ['preview'],
+                    'status': ['deprecated'],
                     'supported_by': 'community'}
 
 DOCUMENTATION = r'''
 ---
 module: dellemc_ome_template
 short_description: Create, modify or deploy a template.
 version_added: "2.8"
+deprecated:
+  removed_in: "3.3"
+  why: Replaced with M(ome_template).
+  alternative: Use M(ome_template) instead.
 description: This module creates, modifies or deploys a template.
 options:
   hostname:
@@ -204,7 +208,7 @@
 
 import json
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.remote_management.dellemc.dellemc_ome import RestOME
+from ansible.module_utils.remote_management.dellemc.ome import RestOME
 from ansible.module_utils.six.moves.urllib.error import URLError, HTTPError
 from ansible.module_utils.urls import ConnectionError, SSLValidationError
 
@@ -365,7 +369,9 @@ def main():
                      ['state', 'modify', ['template_id', 'attributes']],
                      ['state', 'deploy', ['template_id']], ],
         supports_check_mode=False)
-
+    module.deprecate("The 'dellemc_ome_template' module has been deprecated. "
+                     "Use 'ome_template' instead",
+                     version=3.3)
     try:
         _validate_inputs(module)
         with RestOME(module.params, req_session=True) as rest_obj:

library/dellemc/ome/dellemc_ome_template_facts.py → deprecated/_dellemc_ome_template_facts.py

@@ -16,14 +16,18 @@
 __metaclass__ = type
 
 ANSIBLE_METADATA = {'metadata_version': '1.1',
-                    'status': ['preview'],
+                    'status': ['deprecated'],
                     'supported_by': 'community'}
 
 DOCUMENTATION = r'''
 ---
 module: dellemc_ome_template_facts
 short_description: Retrieves template details.
 version_added: "2.9"
+deprecated:
+  removed_in: "3.3"
+  why: Replaced with M(ome_template_info).
+  alternative: Use M(ome_template_info) instead.
 description:
    - This module retrieves the list and details of all templates.
 options:
@@ -92,7 +96,7 @@
             "IsStatelessAvailable": false,
             "LastUpdatedBy": null,
             "LastUpdatedTime": "1970-01-31 00:00:56.372144",
-            "Name": "iDRAC 14G Enable Performance Profile for Virtualization",
+            "Name": "iDRAC Enable Performance Profile for Virtualization",
             "SourceDeviceId": 0,
             "Status": 0,
             "TaskId": 0,
@@ -104,7 +108,7 @@
 
 import json
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.remote_management.dellemc.dellemc_ome import RestOME
+from ansible.module_utils.remote_management.dellemc.ome import RestOME
 from ansible.module_utils.six.moves.urllib.error import URLError, HTTPError
 from ansible.module_utils.urls import ConnectionError, SSLValidationError
 
@@ -120,6 +124,9 @@ def main():
         },
         supports_check_mode=False
     )
+    module.deprecate("The 'dellemc_ome_template_facts' module has been deprecated. "
+                     "Use 'ome_template_info' instead",
+                     version=3.3)
     template_uri = "TemplateService/Templates"
     try:
         with RestOME(module.params, req_session=True) as rest_obj:

library/dellemc/ome/dellemc_ome_user_facts.py → deprecated/_dellemc_ome_user_facts.py

@@ -15,14 +15,18 @@
 __metaclass__ = type
 
 ANSIBLE_METADATA = {'metadata_version': '1.1',
-                    'status': ['preview'],
+                    'status': ['deprecated'],
                     'supported_by': 'community'}
 
 DOCUMENTATION = r'''
 ---
 module: dellemc_ome_user_facts
 short_description: Retrieves details of all accounts or a specific account.
 version_added: "2.9"
+deprecated:
+  removed_in: "3.3"
+  why: Replaced with M(ome_user_info).
+  alternative: Use M(ome_user_info) instead.
 description:
    - This module retrieves the list and basic details of all accounts or details of a specific account.
 options:
@@ -96,7 +100,7 @@
 
 import json
 from ansible.module_utils.basic import AnsibleModule
-from ansible.module_utils.remote_management.dellemc.dellemc_ome import RestOME
+from ansible.module_utils.remote_management.dellemc.ome import RestOME
 from ansible.module_utils.six.moves.urllib.error import URLError, HTTPError
 from ansible.module_utils.urls import ConnectionError, SSLValidationError
 
@@ -112,6 +116,9 @@ def main():
         },
         supports_check_mode=False
     )
+    module.deprecate("The 'dellemc_ome_user_facts' module has been deprecated. "
+                     "Use 'ome_user_info' instead",
+                     version=3.3)
     account_uri = "AccountService/Accounts"
     try:
         with RestOME(module.params, req_session=True) as rest_obj: