Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCR-14625 add Apply #8

Merged
merged 7 commits into from
Jan 24, 2024
Merged

NCR-14625 add Apply #8

merged 7 commits into from
Jan 24, 2024

Conversation

solokirrik
Copy link
Contributor

No description provided.

* enable t.Parallel() (40s to 7.4s local tests execution reduction)
* update owners
Copy link
Collaborator

@marksalpeter marksalpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a useful addition to the lib and I appreciate the test coverage. This needs a make readme to update the readme file.

merge_example_test.go Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Collaborator

@marksalpeter marksalpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice feature 👍

@marksalpeter
Copy link
Collaborator

Can you add an example for the new Apply function in the readme/godoc?

@solokirrik solokirrik merged commit b8ea372 into main Jan 24, 2024
4 checks passed
@solokirrik solokirrik deleted the NCR-14625-apply-for-multitoken branch January 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants