Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qv experiment #1

Merged
merged 33 commits into from
Jul 12, 2021
Merged

Conversation

gadial
Copy link

@gadial gadial commented Jul 12, 2021

Summary

Details and comments

dekelmeirom and others added 30 commits July 8, 2021 15:30
fix a bug with qubits not in order, split experiment and simulation data
* * First draft of rough Drag.

* * Restricted to three series.

* * Renamed files.
* Improved: tests, fitting, defaults, black, lint, docs.

* * Docstring.

* * Improved docs, made phase range larger.

* * Black and lint

* * Black.

* * Made initial guesses more robust.
* Aligned tests with most recent main branch.

* * Added Drag update methodology.
* Refactored update library.

* * Removed check on Drag pulses.

* * Renamed the rotations.

* * Fixed test updated library.

* * Improved saftey chacks on parameters with tests.

* * Changed default measurement level from 1 to 2.

* * Split experiment and analysis.

* * Improved docstring.

* * Shortened reps error message.

* * Simplified barriers.

* * Updated fit function.

* * Docstring.

* * Freq bound and lint.

* * Black.

* * Improved docstring.

* * Added default conversion from rp to rm when only rp is given.

* * Refactored circuit generation.

* * Fix tests.

* * Black.
* add fixed parameter to curve analysis

* black & lint

* black & lint

* Update qiskit_experiments/analysis/curve_analysis.py

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>

Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>
Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com>
* move from terra

* run black

* convert service exception to log

* fix lint

* log post processing failure

* remove data index

* fix test can package typo

* remove experiment_class and result_class

* fix lint

* doc update

Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>

* rename classes

* review comments

* fix lint

* review comments

* fix lint

* add db service to doc

* fix doc

* remove extra service keyword

* fix type hint

* review comments

Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com>
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
…munity#150)

* initial commit model based experiment

* Revert "initial commit model based experiment"

This reverts commit eb60945.

* add experiment metadata

* add exception for zero job-metadata

* update metadata storing logic

* docs and annotation update (by Yael)

* black & lint

Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com>
* Added 2-qubit epg computation test

* Fixed input correctness tests

* Additional test fixes; tests are now passing

* Style fix

* Additional data print for failing tests

* Change in default ATOL for some tests

* Structure test for interleaved RB + another ATOL change

* Added coherence test

* Generated new test data with longer RB sequence for 1 qubit

* Fixes to data generation

* Added interleaved RB json files

* Abstracting out the RB analysis tests

* Now runs interleaved RB tests

* Linting

* Linting

* Small fixes after the merge
* wip guesses

* update fft code

* add tests

* lint

* comments
- add get_height function to remove duplicated code
- add fwhm guess
- add baseline guesses

* update rabi and spect

* black & lint

* update documentation

* fix bug

* make module singular form

* udpate documentation

* fix bug of fft with non-uniform sampling
* * Implemented method to setup single-qubit calibrations.

* * Refactored the default data processor logic in the Rabi experiment.

* * Removed files that should no be there.

* * Added logic in curve_analysis to get a default data processor based on run metadata.

* Update qiskit_experiments/analysis/curve_analysis.py

Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>

* Update qiskit_experiments/analysis/curve_analysis.py

Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>

* * Refactored data processor extraction.

* * Lint.

* * Added mandatory run metadata to analysis tests.

* empty commit to rerun CI

* * Renamed the data processor getter.

* * Added MeasLevel.CLASSIFIED to the default run options.

* * Move data processor getting out of try-except.

* Update curve_analysis.py

* Update curve_analysis.py

Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* draw confidence interval only for T1 and RB

* replaced 'confidence interval' with 'fit uncertainty'
* Initial tutorial for t2star including backend

* Fixed bug when no default values are given for p0; added tests for these cases; removed check that result is close to estimated result; cleaned up code related to dt

* Removed plotting figures by default

* black and lint

* Tutorial for T2Ramsey experiment

* Moved backend to new location, added usage of MockJob

* Updated changes that were made in test_t2ramsey into the backend

* lint and black

* Put back plot that was missing. Removed t2star_tutorial.ipynb that was there by mistake

* Changed s to t in formula. Put back last example that disappeared mysteriously.

* Changed x to t in formula. Put back missing last example

* Changed names t2star to t2ramsey. Merged with main

* Fixed emphasis in text box

* Fixed * in text box

* Added back the last plot

* Fixes concerning units and conversion_factor

* updates from main

* lint

* black

* Added text boxes to the graphs, to be more similar to t1 and rb tutorials

* Fixed the description of the experiment

* Small syntax corrections

* Added paragraph on providing initial user estimates

* Added title adding data to an existing experiment

* black

* Fixed scaling on x-axis in graphs

* Fixed title

Co-authored-by: Yael Ben-Haim <yaelbh@il.ibm.com>
@dekelmeirom dekelmeirom merged commit 3d237cc into dekelmeirom:qv_experiment Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants