Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic during error returning if Dataset\Query couldn't have found #48

Merged
merged 4 commits into from
Nov 29, 2022

Conversation

Tsovak
Copy link
Contributor

@Tsovak Tsovak commented Nov 29, 2022

the application panics when couldn't find a query. at this point, it returns return nil, status.Error(codes.NotFound, err.Error()). but here err is nil because 2 lines above we check that

		log.Err(err).Send()
		return nil, status.Error(codes.Internal, err.Error())
	}

just couldn't find a Dataset\Query

I just deleted panic cause (err.Error()) and added just a message

@Tsovak Tsovak changed the title fix panic during error returning Fix panic during error returning if Dataset\Query couldn't have found Nov 29, 2022
src/server/dekart/query.go Outdated Show resolved Hide resolved
src/server/dekart/query.go Outdated Show resolved Hide resolved
@Tsovak Tsovak requested a review from delfrrr November 29, 2022 10:40
@delfrrr delfrrr merged commit 4c80555 into dekart-xyz:main Nov 29, 2022
@Tsovak Tsovak deleted the tsovak/fix-panic branch November 29, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants