-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to convert ActionDispatch::Request/Response to JSON #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpaca-tc
force-pushed
the
support_rails6_1
branch
from
December 31, 2020 07:39
e348f3c
to
bf9f7bf
Compare
alpaca-tc
force-pushed
the
support_rails6_1
branch
from
December 31, 2020 11:13
bf9f7bf
to
4133c4e
Compare
Any chance to get a review/merge and a new gem version for this fix? |
For anyone interested - a monkey patch based on this PR, which you can put into a file under
|
Thanks for the fix! |
evazion
added a commit
to danbooru/danbooru
that referenced
this pull request
Mar 25, 2021
Remove a workaround added in 2c06766. meta_request had a bug that caused Rails to fail to launch under Rails 6.1. The fix was finally merged upstream. hxxps://github.com/dejan/rails_panel/pull/177.
eyupatis
added a commit
to eyupatis/ruby-tr
that referenced
this pull request
Mar 27, 2021
eyupatis
added a commit
to eyupatis/ruby-tr
that referenced
this pull request
Apr 2, 2021
MuhammetDilmac
pushed a commit
to rubytr/ruby-tr
that referenced
this pull request
Apr 2, 2021
* upgrade rails version to rails 6.1.3.1 and ruby version to 2.6.6 * make changes to the files after running rails app:update * fix small problems on db/schema.rb file * fix rubocop error * update contributing documentation to include necessary commands * remove meta_request gem, because it is not compatible with rails 6.1.x See rails/rails#40781 and dejan/rails_panel#177 (comment) for more details * change cookies serializer to hybrid to not break existing cookies For more details: https://bigbinary.com/blog/migrating-existing-session-cookies-while-upgrading-to-rails-4-1-and-above * change ruby versions in workflow and .ruby-version file * add ruby installation step to contributing.md file * drop old index name for active admin comments This will be helpful to the developers who had the database and run migrations in the past. It will basically remove the index with the old name and it will create the index with the new name. * rename old index name, instead of dropping it and creating new one
MuhammetDilmac
pushed a commit
to rubytr/ruby-tr
that referenced
this pull request
Apr 2, 2021
* upgrade rails version to rails 6.1.3.1 and ruby version to 2.6.6 * make changes to the files after running rails app:update * fix small problems on db/schema.rb file * fix rubocop error * update contributing documentation to include necessary commands * remove meta_request gem, because it is not compatible with rails 6.1.x See rails/rails#40781 and dejan/rails_panel#177 (comment) for more details * change cookies serializer to hybrid to not break existing cookies For more details: https://bigbinary.com/blog/migrating-existing-session-cookies-while-upgrading-to-rails-4-1-and-above * change ruby versions in workflow and .ruby-version file * add ruby installation step to contributing.md file * drop old index name for active admin comments This will be helpful to the developers who had the database and run migrations in the past. It will basically remove the index with the old name and it will create the index with the new name. * rename old index name, instead of dropping it and creating new one * update pg gem to v1.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Rails 6.1, the payload of action dispatch can't be converted.
It's not guaranteed
to_json
conversion, andSystemStackError
got to happen.To avoid this, fixed to ignore
ActionDispatch::Request/ActionDispatch::Response
to JSON.and added test for rails 6.1