feat(normalize_storage): use MINIO_BUCKET env-var
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it. |
drgarcia1986
force-pushed
the
minio-bucket-fix
branch
from
9dc46d7 to
0da686e
Compare
|
related deis/slugrunner#66 |
|
Jenkins, add to whitelist. |
|
Looks like |
drgarcia1986
force-pushed
the
minio-bucket-fix
branch
from
0da686e to
7c44b0f
Compare
|
Oh sure, make sense, sorry my bad! |
mboersma
reviewed
Aug 3, 2017
rootfs/bin/normalize_storage
Outdated
| @@ -1,8 +1,9 @@ | |||
| #!/usr/bin/env bash | |||
| export BUCKET_FILE=/var/run/secrets/deis/objectstore/creds/builder-bucket | |||
| if [ "$BUILDER_STORAGE" == "minio" ]; then | |||
| MINION_BUCKET_NAME=${MINIO_BUCKET:-git} | |||
There was a problem hiding this comment.
Could you make this MINIO_BUCKET_NAME (not MINION)?
Use MINIO_BUCKET environment variable to define the bucket name for minio storage type instead of hardcoded `git` If there isnt a value on MINIO_BUCKET var, normalize_storage will use `git` by default
drgarcia1986
force-pushed
the
minio-bucket-fix
branch
from
7c44b0f to
4e0c17c
Compare
|
Hi @mboersma , Is there something then I need to fix? |
|
@drgarcia1986 not your problem as far as I can tell, it looks like we have some issues with the e2e tests. I'll be looking at that today and get it sorted out. |
|
@mboersma tks 👍 |
|
Jenkins, test this please. |
|
c'mon jenkins, be nice to me :/ |
mboersma
approved these changes
Aug 8, 2017
vdice
approved these changes
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use MINIO_BUCKET environment variable to define the bucket name for minio storage type
instead of hardcoded
gitIf there isnt a value on MINIO_BUCKET var, normalize_storage will use
gitby default