Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error occurred. during discovery process #46

Closed
gcampagnoli opened this issue Dec 27, 2020 · 2 comments
Closed

Error occurred. during discovery process #46

gcampagnoli opened this issue Dec 27, 2020 · 2 comments

Comments

@gcampagnoli
Copy link

Hi, thanks for the update, but now during discovery process, find my devices, but failed with a generic error,

Error occurred.

`--- build/lib/aircon/main.py 2020-12-27 19:34:44.000000000 +0100
+++ aircon/main.py 2020-12-27 19:38:30.989961055 +0100
@@ -243,7 +243,8 @@
parsed_args.passwd, parsed_args.prefix,
parsed_args.device,
parsed_args.properties)

  • except:
  • except Exception as ex:
  •  print(ex)
     print('Error occurred.')
     sys.exit(1)
    

`

Is missing async in perform_discovery in discovery.py

--- build/lib/aircon/discovery.py 2020-12-27 19:34:44.000000000 +0100
+++ aircon/discovery.py 2020-12-27 19:40:12.689961016 +0100
@@ -104,7 +104,7 @@
pass # Not gzipped.
return json.loads(resp_data)

-def perform_discovery(app: str, user: str, passwd: str,
+async def perform_discovery(app: str, user: str, passwd: str,
prefix: str, device_filter: str,
properties_filter: bool) -> dict:
if app in SECRET_ID_MAP:

deiger added a commit that referenced this issue Dec 28, 2020
@deiger
Copy link
Owner

deiger commented Dec 28, 2020

Thanks for the issue, this should now be fixed.

@deiger deiger closed this as completed Dec 28, 2020
@SvenStorck
Copy link

I can confirm that it works now without the generic error and creates a config file!

ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants