-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #518: Textarea and select value isn't preserved #542
Open
the-ress
wants to merge
4
commits into
defunkt:master
Choose a base branch
from
the-ress:issue518
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dc4ab30
Fixed issue #518: Textarea and select value isn't preserved when goin…
the-ress f9c0614
Add tests for form value preservation when traversing history
masone 0f86c73
Fixed preserving single select value when going back and forward
the-ress a96fa19
Merge remote-tracking branch 'remotes/masone/form_tests' into issue518
the-ress File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -562,6 +562,21 @@ function uniqueId() { | |
} | ||
|
||
function cloneContents(container) { | ||
// Preserve textarea values | ||
var textarea = findAll(container, "textarea") | ||
textarea.text(function(i, text){return textarea[i].value}) | ||
|
||
// Preserve select values | ||
findAll(container, "select").each(function(i, elem){ | ||
elem = $(elem); | ||
var values = $(elem).val(); | ||
values = $.isArray(values) ? values : [values]; | ||
elem.find('option[selected]').attr('selected', false); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not happy that this performs DOM changes on elements before they are cloned. How about just making these changes on the elements after they have been cloned? |
||
elem.find('option').filter(function(){ | ||
return ($.inArray(this.value, values) !== -1); | ||
}).attr('selected', true); | ||
}) | ||
|
||
var cloned = container.clone() | ||
// Unmark script tags as already being eval'd so they can get executed again | ||
// when restored from cache. HAXX: Uses jQuery internal method. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<%= title 'Form' %> | ||
|
||
<form action="env.html" method="GET"> | ||
<input type="text" value="foo"> | ||
<textarea>foo</textarea> | ||
|
||
<input type="checkbox" value="foo"> | ||
<input type="radio" value="foo"> | ||
|
||
<select> | ||
<option value="foo">foo</option> | ||
<option value="bar">bar</option> | ||
<option value="baz">baz</option> | ||
</select> | ||
|
||
</form> | ||
|
||
<script type="text/javascript">window.parent.iframeLoad(window)</script> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isnt this missing a
.each
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, text() has similar functionality: http://api.jquery.com/text/#text-function