chore: swap to openid-connect instead of _ (#124)

## Description

Swap over to accept `openid-connect` instead of `openid_connect`.

## Related Issue

Fixes #N/A

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/uds-package-gitlab/blob/main/CONTRIBUTING.md#developer-workflow)
followed

Release-As: v9.10.1-uds.1

chart/templates/NOTES.txt

@@ -0,0 +1,8 @@
+{{- $NOTICE := "\n=== NOTICE" -}}
+{{- $WARNING := "\n=== WARNING" -}}
+{{- $CRITICAL := "\n=== CRITICAL" -}}
+
+{{- if eq .Values.sso.protocol "openid_connect" }}
+{{ $NOTICE }}
+Setting `.sso.protocol` to `openid_connect` has been deprecated - please switch to using `openid-connect` instead
+{{- end }}

chart/templates/uds-package.yaml

@@ -17,7 +17,7 @@ spec:
         - "mapper-oidc-mattermostid-id"
         - "mapper-oidc-email-email"
         {{ end }}
-        {{ if eq .Values.sso.protocol "openid_connect" }}
+        {{ if or (eq .Values.sso.protocol "openid_connect") (eq .Values.sso.protocol "openid-connect") }}
         - "profile"
         - "email"
         {{ end }}
@@ -32,7 +32,7 @@ spec:
         MM_GITLABSETTINGS_TOKENENDPOINT: "http://keycloak-http.keycloak.svc.cluster.local:8080/realms/uds/protocol/openid-connect/token"
         MM_GITLABSETTINGS_USERAPIENDPOINT: "https://sso.{{ .Values.domain }}/realms/uds/protocol/openid-connect/userinfo"
         {{ end }}
-        {{ if eq .Values.sso.protocol "openid_connect" }}
+        {{ if or (eq .Values.sso.protocol "openid_connect") (eq .Values.sso.protocol "openid-connect") }}
         MM_OPENIDSETTINGS_ENABLE: "{{ .Values.sso.enabled | toString }}"
         MM_OPENIDSETTINGS_BUTTONTEXT: "{{ .Values.sso.login_button_text }}"
         MM_OPENIDSETTINGS_BUTTONCOLOR: "{{ .Values.sso.login_button_color }}"

chart/values.yaml

@@ -29,7 +29,7 @@ postgres:
 mattermostLicense: ""
 sso:
   enabled: true
-  # Options: "gitlab", "openid_connect"
+  # Options: "gitlab", "openid-connect"
   protocol: "gitlab"
   secretName: mattermost-sso