Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add workflow for scanning unicorn core for CVEs #1274

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

mjnagel
Copy link
Contributor

@mjnagel mjnagel commented Feb 13, 2025

Description

This adds a new task file for scanning for CVEs as well as a workflow to run a nightly scan against the latest unicorn flavor core release.

The tasks are built to be dynamic to allow for scanning other packages/versions/flavors as needed and adjust the reporting threshold.

The workflow will specifically scan the latest release of core (unicorn flavor) and create a github issue with all High/Critical CVEs listed for triaging/fixing.

Related Issue

Fixes #1273

Closes #1162 - this will replace the need to trigger security-hub's scanning.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Steps to Validate

This workflow was partially tested on my test repo here (run against registry1 flavor due to permissions for private packages):

Checklist before merging

@mjnagel mjnagel self-assigned this Feb 13, 2025
@mjnagel mjnagel marked this pull request as ready for review February 13, 2025 00:55
@mjnagel mjnagel requested a review from a team as a code owner February 13, 2025 00:55
koesbong
koesbong previously approved these changes Feb 13, 2025
@mjnagel mjnagel marked this pull request as draft February 13, 2025 15:49
@mjnagel
Copy link
Contributor Author

mjnagel commented Feb 13, 2025

Going to make a few changes here:

  • Updating this to run right after a release so that we have a fresh scan immediately
  • May update the format of the output to be more readable/concise

@koesbong
Copy link

Going to make a few changes here:

  • Updating this to run right after a release so that we have a fresh scan immediately
  • May update the format of the output to be more readable

So it'll run nightly and also right after a release?

@mjnagel
Copy link
Contributor Author

mjnagel commented Feb 13, 2025

@koesbong correct yeah, that way a scan is never older than 24 hours, but we also have a scan immediately upon release.

@mjnagel mjnagel marked this pull request as ready for review February 13, 2025 17:45
@mjnagel
Copy link
Contributor Author

mjnagel commented Feb 13, 2025

Updated, workflow will now run everyday + right after a release is published. The format was also updated for the markdown to be more concise and use dropdowns for each image (hiding the full CVE tables by default). Example of that can be viewed on the linked github issue or from the artifact for the most recent job here. I also added a basic task readme with an example of how to run this scan job locally.

Copy link
Contributor

@UnicornChance UnicornChance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjnagel mjnagel enabled auto-merge (squash) February 13, 2025 18:50
@mjnagel mjnagel merged commit d7226be into main Feb 13, 2025
23 checks passed
@mjnagel mjnagel deleted the cve-scan-workflow branch February 13, 2025 18:51
UnicornChance pushed a commit that referenced this pull request Feb 19, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.36.0](v0.35.0...v0.36.0)
(2025-02-18)


### Features

* introduced a new option CREATE_OPTIONS and skip SBOMs in tests
([#1268](#1268))
([f944bf1](f944bf1))
* **k3d-slim-dev:** add Istio Proxy resource configuration
([#1270](#1270))
([fd4fa3c](fd4fa3c))
* **k3d-slim-dev:** add resource configuration for Istiod and Keycloak
([#1279](#1279))
([07eeea2](07eeea2))
* loki schema config management
([#1224](#1224))
([e16fdb1](e16fdb1))


### Bug Fixes

* add Keycloak workaround for Kernels 6.12+
([#1218](#1218))
([bb634a6](bb634a6))
* added network restriction tests
([#1250](#1250))
([9ef6c2b](9ef6c2b))
* always upload CVE report
([#1286](#1286))
([e97b6b9](e97b6b9))
* image name parsing for cve scan
([#1294](#1294))
([7f3b53b](7f3b53b))
* lint errors on unused caught errors
([#1271](#1271))
([ccd824e](ccd824e))


### Miscellaneous

* add json schema generation
([#1264](#1264))
([9eee462](9eee462))
* **ci:** add workflow for scanning unicorn core for CVEs
([#1274](#1274))
([d7226be](d7226be))
* **deps:** remove keycloak registry1 flavor architecture restriction
([#1267](#1267))
([c50b081](c50b081))
* **deps:** update grafana
([#1242](#1242))
([73331d4](73331d4))
* **deps:** update grafana to v8.12.1
([#1276](#1276))
([ca60ca5](ca60ca5))
* **deps:** update istio to v1.24.3
([#1266](#1266))
([27acb5d](27acb5d))
* **deps:** update keycloak
([#1184](#1184))
([71fd910](71fd910))
* **deps:** update keycloak to v0.10.1
([#1298](#1298))
([e552e24](e552e24))
* **deps:** update keycloak to v26.1.1
([#1258](#1258))
([f3a3731](f3a3731))
* **deps:** update keycloak to v26.1.2
([#1269](#1269))
([3301bab](3301bab))
* **deps:** update loki
([#1202](#1202))
([79f8209](79f8209))
* **deps:** update neuvector registry1 scanner and unicorn updater
([#1261](#1261))
([8b4ed68](8b4ed68))
* **deps:** update neuvector updater image for unicorn flavor to v8.12.1
([#1284](#1284))
([8c7bb17](8c7bb17))
* **deps:** update pepr to v0.45.0
([#1252](#1252))
([8be12db](8be12db))
* **deps:** update prometheus-stack
([#1255](#1255))
([1a316a2](1a316a2))
* **deps:** update prometheus-stack to v68.4.4
([#1244](#1244))
([8053443](8053443))
* **deps:** update support-deps
([#1251](#1251))
([30db8f0](30db8f0))
* **deps:** update support-deps
([#1260](#1260))
([e0e2523](e0e2523))
* **deps:** update support-deps
([#1275](#1275))
([069a201](069a201))
* **deps:** update uds-identity-config image
([#1278](#1278))
([3325662](3325662))
* **deps:** update velero to v1.32.2
([#1277](#1277))
([02db070](02db070))
* switch to registry1 cni image
([#1256](#1256))
([2b564e6](2b564e6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE awareness/notifications for UDS Core
3 participants