-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(oscal): link remapper method component defn #879
Open
meganwolf0
wants to merge
19
commits into
main
Choose a base branch
from
878-link-remapper-method-component-defn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,297
−11
Open
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
ac1e4ec
feat: added OSCALModel impl for compdef
meganwolf0 9005d78
fix: err handling
meganwolf0 d3ac877
Merge branch 'main' into 747-oscalmodel-interface-implementation-for-…
meganwolf0 98bbb25
test: updated component and ssp tests
meganwolf0 1dcd78f
fix: removed NewOscalComponentDefn
meganwolf0 5f6be3f
feat: added oscalmodel for assessment results
meganwolf0 296192f
fix: updated declaration syntax
meganwolf0 9c90ab0
Merge branch '748-oscalmodel-interface-implementation-for-assessment-…
meganwolf0 c3eb583
feat: added RewritePaths method on compdef
meganwolf0 91734a7
fix: err handling
meganwolf0 351701f
Merge remote-tracking branch 'origin/main' into 878-link-remapper-met…
meganwolf0 17254c9
fix: updated handling opaque files
meganwolf0 fc14483
feat: updated method to identify path rewrites
meganwolf0 ea09669
fix: removed copypasta
meganwolf0 458f73a
fix: removed test change
meganwolf0 32fcdd8
Merge branch 'main' into 878-link-remapper-method-component-defn
meganwolf0 f687f4e
Merge branch 'main' into 878-link-remapper-method-component-defn
meganwolf0 ff78d2a
feat: disaggregated rewrite fcns
meganwolf0 6d4a4ad
Merge branch '878-link-remapper-method-component-defn' of https://git…
meganwolf0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method name isn'g telling me anything, and it's not obvious to me why it returns an empty string if given an abs path but a full path to a directory if given a relative path. Can you add some comments that explains why this is the behavior? And maybe rename it -
returnBaseDirIfNotAbsPath
seems like a more accurate description of what's happening (though I still wonder why)