Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async tp allreduce #7115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

async tp allreduce #7115

wants to merge 1 commit into from

Conversation

inkcherry
Copy link
Contributor

@inkcherry inkcherry commented Mar 7, 2025 •
edited
Loading

(wip) ->add config.

hwchen2017
hwchen2017 reviewed Mar 7, 2025
View reviewed changes
deepspeed/module_inject/layers.py
output = torch.matmul(input, self.weight.transpose(-1, -2))
if self.bias is not None:
output += self.bias
if True:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of either non-async or async column parallel is supposed to be configurable.

hwchen2017
hwchen2017 reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@hwchen2017 hwchen2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the format error by running pre-commit and DCO error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchen2017 hwchen2017 hwchen2017 left review comments

@loadams loadams Awaiting requested review from loadams loadams is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inkcherry @hwchen2017