Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for HF integrations CI #4769

Closed
wants to merge 21 commits into from
Closed

Fix for HF integrations CI #4769

wants to merge 21 commits into from

Conversation

mrwyattii
Copy link
Contributor

@mrwyattii mrwyattii commented Dec 4, 2023 •
edited
Loading

There were several problems with the Transformers and Accelerate unit tests:

@mrwyattii mrwyattii requested a review from loadams as a code owner December 4, 2023 17:41
@mrwyattii mrwyattii changed the title Fix for accelerate unit tests [DO NOT MERGE] Fix for accelerate unit tests Dec 4, 2023
@mrwyattii mrwyattii requested a review from awan-10 as a code owner December 14, 2023 18:55
@mrwyattii mrwyattii requested a review from tjruwase as a code owner December 14, 2023 20:03
@mrwyattii mrwyattii changed the title [DO NOT MERGE] Fix for accelerate unit tests [DO NOT MERGE] Fix for HF integrations CI Dec 14, 2023
@mrwyattii mrwyattii changed the title [DO NOT MERGE] Fix for HF integrations CI Fix for HF integrations CI Dec 14, 2023
This was referenced Dec 14, 2023
Closed
Open
@loadams loadams linked an issue Dec 14, 2023 that may be closed by this pull request
DeepSpeed CI failures in Transformers with the latest version 0.12.4 but works with 0.12.3 #4795
Closed
mrwyattii added a commit that referenced this pull request Dec 15, 2023
@mrwyattii
bring in fix for accelerate from #4769
b65b823
This was referenced Dec 15, 2023
Merged
Merged
mrwyattii added a commit that referenced this pull request Dec 15, 2023
@mrwyattii
Refactor launcher user arg parsing (#4824)
d37fc25 
Splitting work from #4769 because we are still debugging transformers
integration issues.

Parsing was broken for user arguments (see #4795). Additionally, parsing
of user arguments is tricky and there are lots of edge cases. For
example: #4660, #4716, #3967. I've attempted to accommodate all of the
possible types of string inputs and added unit tests.
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
@mrwyattii
Refactor launcher user arg parsing (deepspeedai#4824)
d05ab5d 
Splitting work from deepspeedai#4769 because we are still debugging transformers
integration issues.

Parsing was broken for user arguments (see deepspeedai#4795). Additionally, parsing
of user arguments is tricky and there are lots of edge cases. For
example: deepspeedai#4660, deepspeedai#4716, deepspeedai#3967. I've attempted to accommodate all of the
possible types of string inputs and added unit tests.
@loadams loadams closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lekurile lekurile lekurile approved these changes

@loadams loadams loadams approved these changes

@awan-10 awan-10 Awaiting requested review from awan-10

@tjruwase tjruwase Awaiting requested review from tjruwase

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeepSpeed CI failures in Transformers with the latest version 0.12.4 but works with 0.12.3
3 participants
@mrwyattii @lekurile @loadams