Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate dataframe in AzureOCRDocumentConverter #8885

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sjrl
Copy link
Contributor

@sjrl sjrl commented Feb 20, 2025

Related Issues

Proposed Changes:

Removes saving of table documents as dataframes. Instead saves them as CSV strings.

How did you test it?

Todo

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@github-actions github-actions bot added the type:documentation Improvements on the docs label Feb 20, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13456021485

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 90.144%

Files with Coverage Reduction New Missed Lines %
components/converters/azure.py 20 89.2%
Totals Coverage Status
Change from base Build 13455055613: -0.01%
Covered Lines: 9485
Relevant Lines: 10522

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor AzureOCRDocumentConverter to not produce Documents with the dataframe field
2 participants