fix: PDFMinerToDocument convert function - adding double new lines between each container_text so that passages can be detected.

[davidsbatista]

Related Issues

• fixes Document Splitter always returns 1 document for split_type="passage" in pdfs #8491

Proposed Changes:

• adding double new lines between container_texts so that passages can be detected
• added tests for this new change using PDF files from our test_files
• I added one more test for page detection to make sure this update doesn't change its behavior

How did you test it?

• manual verification and unit tests
• CI tests

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[coveralls]

Pull Request Test Coverage Report for Build 12829355379

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.004%) to 91.306%

---

Totals
Change from base Build 12829186498:	0.004%
Covered Lines:	8853
Relevant Lines:	9696

---

💛 - Coveralls

[mpangrazzi]

LGTM

[davidsbatista]

@anakin87 @julian-risch do you also want to have a quick look on this one?

[anakin87]

Looks good.

I would take the opportunity to also change the following line:

haystack/haystack/components/converters/pdfminer.py

Line 159 in 62ac27c

pdf_reader = extract_pages(io.BytesIO(bytestream.data), laparams=self.layout_params)

pdf_reader is misleading here: these are pages