-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove pipeline experiments #214
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@davidsbatista @Amnah199 with this PR, I also released the tool to compare traces. I thought about keeping it but since you need to import the old pipeline implementation and the new pipeline at the same time, you can't compare traces anyways with a new release. If people want to compare old Haystack pipeline against new pipeline, they have to downgrade to @bilgeyucel @dfokina should we turn a version of the AsyncPipeline notebook into a cookbook? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathislucka the AsyncPipeline notebook is already a cookbook here except for the last "Running components concurrently" section. Is that part the only addition to the example?
@@ -44,8 +44,6 @@ that includes it. Once it reaches the end of its lifespan, the experiment will b | |||
| [`InMemoryChatMessageStore`][7] | Memory Store | December 2024 | None | <a href="https://colab.research.google.com/github/deepset-ai/haystack-cookbook/blob/main/notebooks/conversational_rag_using_memory.ipynb" target="_parent"><img src="https://colab.research.google.com/assets/colab-badge.svg" alt="Open In Colab"/> | [Discuss](https://github.com/deepset-ai/haystack-experimental/discussions/75) | | |||
| [`Auto-Merging Retriever`][8] & [`HierarchicalDocumentSplitter`][9] | Document Splitting & Retrieval Technique | December 2024 | None | <a href="https://colab.research.google.com/github/deepset-ai/haystack-cookbook/blob/main/notebooks/auto_merging_retriever.ipynb" target="_parent"><img src="https://colab.research.google.com/assets/colab-badge.svg" alt="Open In Colab"/> | [Discuss](https://github.com/deepset-ai/haystack-experimental/discussions/78) | | |||
| [`LLMMetadataExtractor`][13] | Metadata extraction with LLM | December 2024 | None | <a href="https://colab.research.google.com/github/deepset-ai/haystack-experimental/blob/main/examples/metadata_extraction_with_llm_metadata_extractor.ipynb" target="_parent"><img src="https://colab.research.google.com/assets/colab-badge.svg" alt="Open In Colab"/> | [Discuss](https://github.com/deepset-ai/haystack-experimental/discussions/130) | | |||
| [`AsyncPipeline`][17] | Async Pipeline & Components | February 2024 | None | <a href="https://colab.research.google.com/github/deepset-ai/haystack-experimental/blob/main/examples/async_pipeline.ipynb" target="_parent"><img src="https://colab.research.google.com/assets/colab-badge.svg" alt="Open In Colab"/> | [Discuss](https://github.com/deepset-ai/haystack-experimental/discussions/152) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathislucka Can you add ready-made super components and Agent
to the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do that in separate PRs. I just want to get this one merged so that I don't get merge conflicts (see #211)
Oh, didn't see that. It's the old implementation from Madeesh that lists "running components concurrently" as a non-goal. I'd say we should update it. I can work on that. |
Pull Request Test Coverage Report for Build 13627828667Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 13627831409Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.