fix: OpenAI Chat Generator - do not create TextContent if content is None; make Anthropic Chat Generator more robust
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11663103763Details
💛 - Coveralls |
anakin87
requested review from
shadeMe and
vblagoje
and removed request for
a team
|
@anakin87 reno note so we remember and communicate this decision? |
|
We don't have Reno in this repository. |
Sorry, too many context switches for me 🤦 |
|
I put this on draft... After more experimentation, I think we should also make Anthropic more robust. UPDATE: done |
anakin87
changed the title
TextContent if content is NoneTextContent if content is None; make Anthropic Chat Generator more robust
shadeMe
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
While experimenting in an application with several Chat Generators,
I encountered some errors passing
ChatMessagesgenerated by OpenAI to Anthropic.Our implementation of OpenAI always creates a
TextContent. Anthropic fails with empty text blocks.I think we should not create a ""
TextContentifcontentisNone. We should simply avoid creating itProposed Changes:
Do not create
TextContentifcontentisNone.How did you test it?
CI, enriched existing tests
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.