Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Use HDF5 instead of numpy files #617

Closed
njzjz opened this issue Dec 12, 2021 · 2 comments · Fixed by #1119
Closed

[Feature Request] Use HDF5 instead of numpy files #617

njzjz opened this issue Dec 12, 2021 · 2 comments · Fixed by #1119
Assignees
Labels
enhancement New feature or request

Comments

@njzjz
Copy link
Member

njzjz commented Dec 12, 2021

Summary

For DeePMD-kit training, when there are large numbers of systems, use HDF5 instead of NumPy files.

Detailed Description

When there are large numbers of systems, it consumes a lot of time to transfer large number of small NumPy files to a supercomputer cluster with bad I/O performance. A HDF5 file can store multiple arrays so it is faster to be transfer. The test results produce the behavior.

Further Information, Files, and Links

deepmodeling/deepmd-kit#1163

@wanghan-iapcm
Copy link
Contributor

Do you assume that we can load all systems in the memory? How shall we handle the case that the data size is larger than the memory?

@njzjz
Copy link
Member Author

njzjz commented Jan 25, 2022

HDF5 does not read the whole file into memory. See https://stackoverflow.com/a/40460400

@njzjz njzjz self-assigned this Jun 14, 2022
@njzjz njzjz linked a pull request Jan 17, 2023 that will close this issue
wanghan-iapcm pushed a commit that referenced this issue Jan 19, 2023
Fix #617.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz closed this as completed Jan 28, 2023
@njzjz njzjz added enhancement New feature or request and removed new feature labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants