Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip UTs when we do not have parmed, ase, pymatgen #249

Merged
merged 5 commits into from
Feb 25, 2022
Merged

skip UTs when we do not have parmed, ase, pymatgen #249

merged 5 commits into from
Feb 25, 2022

Conversation

amcadmus
Copy link
Member

No description provided.

@amcadmus amcadmus requested a review from njzjz February 24, 2022 00:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022 •
edited
Loading

Codecov Report

Merging #249 (8719bd7) into devel (4866a2f) will not change coverage.
The diff coverage is n/a.

❗ Current head 8719bd7 differs from pull request most recent head 9789d6d. Consider uploading reports for the commit 9789d6d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #249   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files          59       59           
  Lines        5124     5124           
=======================================
  Hits         4202     4202           
  Misses        922      922

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4866a2f...9789d6d. Read the comment docs.

njzjz
njzjz requested changes Feb 24, 2022
View reviewed changes
wanghan-iapcm and others added 3 commits February 24, 2022 15:54
@wanghan-iapcm @njzjz
Update tests/test_amber_md.py
0136031 
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm @njzjz
Update tests/test_pymatgen_molecule.py
8719bd7 
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm @njzjz
Update tests/test_ase_traj.py
9789d6d 
Co-authored-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@wanghan-iapcm wanghan-iapcm requested a review from njzjz February 24, 2022 07:55
@amcadmus amcadmus merged commit b62f67a into deepmodeling:devel Feb 25, 2022
@amcadmus amcadmus deleted the skip-tests branch February 26, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njzjz njzjz njzjz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amcadmus @codecov-commenter @njzjz @wanghan-iapcm