Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add importlib_metadata as dependency #227

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 22, 2021

No description provided.

Copy link
Collaborator

@AnguseZhang AnguseZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think such requirement is too strict and may cause conflicts, since some of our python environments in offline package are Python3.8.

@njzjz
Copy link
Member Author

njzjz commented Nov 22, 2021

I think such requirement is too strict and may cause conflicts, since some of our python environments in offline package are Python3.8.

It means it takes effect only when Python version is less than 3.8. See https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependencies

@wanghan-iapcm wanghan-iapcm merged commit a2d13e6 into deepmodeling:devel Nov 22, 2021
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Nov 23, 2021
wanghan-iapcm pushed a commit to deepmodeling/deepmd-kit that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants