Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug in PWmat-MOVEMENT converter #138

Merged
merged 2 commits into from
Apr 17, 2021

Conversation

liuliping0315
Copy link
Contributor

Etot in PWmat molecular dynamics: Ep + Ek. (Ep: potential energy; Ek: kinetic energy)
The old version "movement.py" read the Etot=Ep+Ek in MOVEMENT, change it to Ep. (Ep is DFT total energy)
The forces in PWmat-MOVEMENT are dE/dR, lacking a minus sign, add '-' in this commit.

@amcadmus
Copy link
Member

Hi @liuliping0315 Thanks a lot for contributing.
Could you please fix the issues in the unittest? Thank you very much

@liuliping0315
Copy link
Contributor Author

liuliping0315 commented Apr 17, 2021 via email

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #138 (d9dfce2) into devel (3443aec) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##            devel     #138   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files          28       28           
  Lines        3326     3326           
=======================================
  Hits         2806     2806           
  Misses        520      520           
Impacted Files Coverage Δ
dpdata/pwmat/movement.py 77.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3443aec...d9dfce2. Read the comment docs.

@amcadmus amcadmus merged commit 30e6929 into deepmodeling:devel Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants