Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pin jax to 0.5.0 #4613

Merged
merged 3 commits into from
Feb 26, 2025
Merged

CI: pin jax to 0.5.0 #4613

merged 3 commits into from
Feb 26, 2025

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Feb 25, 2025

Summary by CodeRabbit

  • Chores
    • Updated dependency installation in our CI workflows by enforcing explicit version constraints for key libraries to ensure a consistent and stable testing environment.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Copy link
Contributor

coderabbitai bot commented Feb 25, 2025

📝 Walkthrough

Walkthrough

This pull request updates three GitHub Actions workflow files to modify the dependency installation commands. The changes introduce version constraints for tensorflow-cpu (allowing only versions compatible with 2.18.0) and enforce an explicit installation of jax at version 0.5.0. The CUDA workflow is similarly updated to fix the version of jax[cuda12]. No changes were made to any exported or public entities.

Changes

File(s) Summary of Changes
.github/.../test_cc.yml Updated pip install command to include tensorflow-cpu~=2.18.0 and add explicit jax==0.5.0 installation.
.github/.../test_python.yml Modified pip install command to install openmpi along with tensorflow-cpu~=2.18.0 and explicit jax==0.5.0 for Python 3.10 and above.
.github/.../test_cuda.yml Changed installation command from jax[cuda12] to jax[cuda12]==0.5.0, ensuring the exact version is used.

Possibly related PRs

  • ci: speed up Python test  #3776: The changes in the main PR are related to the installation of the jax library, which is also modified in the retrieved PR, specifically regarding version constraints.
  • ci: bump TF to 2.18, PT to 2.5 #4228: The changes in the main PR, which involve specifying version constraints for tensorflow-cpu and jax, are related to the modifications in the retrieved PR that also update the version requirements for jax and tensorflow, indicating a direct connection in dependency management.
  • ci: install GPU JAX in GPU CI #4293: The changes in the main PR regarding the installation of jax with specific version constraints are directly related to the modifications in the retrieved PR, which also involves the installation of jax but with a different specification for CUDA support.

Suggested reviewers

  • wanghan-iapcm

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39f3b5e and e443ff0.

📒 Files selected for processing (1)
  • .github/workflows/test_python.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/test_python.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (d5417fb) to head (e443ff0).
Report is 1 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #4613   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files         680      680           
  Lines       64545    64543    -2     
  Branches     3538     3539    +1     
=======================================
  Hits        54596    54596           
+ Misses       8808     8806    -2     
  Partials     1141     1141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz marked this pull request as ready for review February 25, 2025 15:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

.github/workflows/test_cc.yml:32

  • [nitpick] The jax package is pinned to version 0.5.0 without a conditional marker, unlike in test_python.yml; consider aligning the installation commands to ensure consistent behavior across environments.
source/install/uv_with_retry.sh pip install --system tensorflow-cpu~=2.18.0 jax==0.5.0

.github/workflows/test_cuda.yml:50

  • [nitpick] Pinning jax with the cuda12 extra to version 0.5.0 differs from the approach used in other workflows; verify that this explicit version pinning aligns with your environment's compatibility requirements.
source/install/uv_with_retry.sh pip install --system "tensorflow~=2.18.0rc2" "torch~=2.6.0" "jax[cuda12]==0.5.0"

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Jinzhe Zeng <njzjz@qq.com>
@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Feb 26, 2025
Merged via the queue into deepmodeling:devel with commit 47bbd65 Feb 26, 2025
60 checks passed
@njzjz njzjz added this to the v3.0.2 milestone Mar 1, 2025
njzjz added a commit to njzjz/deepmd-kit that referenced this pull request Mar 1, 2025
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Chores**
- Updated dependency installation in our CI workflows by enforcing
explicit version constraints for key libraries to ensure a consistent
and stable testing environment.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Signed-off-by: Jinzhe Zeng <njzjz@qq.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
(cherry picked from commit 47bbd65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants