Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cc): compile select_map<int> when TensorFlow backend is off #3987

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jul 16, 2024

select_map<int> is currently within the BUILD_TENSORFLOW condition block, which is wrong. The C API uses it. This issue is found on a machine when only building against libtorch.

Summary by CodeRabbit

  • New Features

    • Improved compatibility with TensorFlow by adding conditional compilation directives.
  • Enhancements

    • Enhanced handling of session data with new template functions for vectors and scalars.

…bled

`select_map<int>` is currently within the `BUILD_TENSORFLOW` condition block, which is wrong. The C API uses it.

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz requested a review from wanghan-iapcm July 16, 2024 21:05
Copy link
Contributor

coderabbitai bot commented Jul 16, 2024

Walkthrough

Walkthrough

This change introduces conditional compilation using preprocessor directives to the template functions deepmd::session_get_vector and deepmd::session_get_scalar in the common.cc file. These directives ensure that these functions are compiled only when the BUILD_TENSORFLOW macro is defined. This update likely aims to better manage dependencies and conditional compilation settings related to TensorFlow.

Changes

File Change Summary
source/api_cc/src/... Added #ifdef BUILD_TENSORFLOW and #endif directives around the template functions for session_get_vector and session_get_scalar.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the C++ label Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (0c0878e) to head (def66f9).

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3987      +/-   ##
==========================================
- Coverage   82.83%   82.82%   -0.01%     
==========================================
  Files         522      522              
  Lines       50876    50876              
  Branches     3019     3015       -4     
==========================================
- Hits        42142    42139       -3     
  Misses       7799     7799              
- Partials      935      938       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Jul 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2024
@njzjz njzjz added this pull request to the merge queue Jul 18, 2024
Merged via the queue into deepmodeling:devel with commit 2af69f9 Jul 18, 2024
60 checks passed
@njzjz njzjz deleted the fix-select-map-int branch July 18, 2024 05:11
mtaillefumier pushed a commit to mtaillefumier/deepmd-kit that referenced this pull request Sep 18, 2024
…epmodeling#3987)

`select_map<int>` is currently within the `BUILD_TENSORFLOW` condition
block, which is wrong. The C API uses it. This issue is found on a
machine when only building against libtorch.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Improved compatibility with TensorFlow by adding conditional
compilation directives.
  
- **Enhancements**
- Enhanced handling of session data with new template functions for
vectors and scalars.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants