OP pt: add contiguous in grad output

[CaRoLZhangxy]

#3910

Summary by CodeRabbit

• Bug Fixes
  • Improved tensor handling in the Border class to ensure proper memory management and performance by making tensors contiguous.

[coderabbitai]

Walkthrough

Walkthrough

The recent update made to the Border class in comm.cc involves a small but important modification. Specifically, when assigning the d_local_g1_tensor variable, it now calls the contiguous() function on grad_output[0]. This ensures that the tensor’s memory layout is continuous, which can lead to performance improvements and prevent potential errors due to non-contiguous memory arrangements.

Changes

File	Change Summary
.../op/pt/comm.cc	Updated the assignment of d_local_g1_tensor to include contiguous().

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 17cdcb0 and d18c432.

Files selected for processing (1)

• source/op/pt/comm.cc (1 hunks)

Additional comments not posted (1)

source/op/pt/comm.cc (1)

200-200: Ensure appropriate use of .contiguous() for performance considerations.

The addition of .contiguous() ensures that the tensor is stored in a contiguous block of memory, which can be necessary for certain operations that expect this memory layout. However, this can also have performance implications, especially in a distributed system using MPI and potentially interacting with GPUs.

It's crucial to verify that this change is indeed necessary for the operations that follow and does not introduce unnecessary overhead. If the subsequent operations require a contiguous layout, this change is justified. Otherwise, it might be beneficial to benchmark the performance impact of this change, particularly in scenarios involving large data transfers or operations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (17cdcb0) to head (d18c432).
Report is 117 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #3917      +/-   ##
==========================================
- Coverage   82.72%   82.72%   -0.01%     
==========================================
  Files         519      519              
  Lines       50515    50516       +1     
  Branches     3015     3015              
==========================================
- Hits        41791    41789       -2     
- Misses       7788     7791       +3     
  Partials      936      936              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.